unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: guix-devel@gnu.org
Subject: Re: [OUTREACHY]: Integration of desktop environments into GNU Guix
Date: Tue, 4 Aug 2020 00:29:21 +0200
Message-ID: <20200804002921.39a351a1@scratchpost.org> (raw)
In-Reply-To: <445cfd68-4b49-8d54-6d40-e08fdf2aced3@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 4435 bytes --]

Hi RG,

pushed this patchset to wip-desktop with small changes.

I have the following comments/point out the following problems:

* gtksourceview depends on icedtea (Java) (because it has groovy as native-input),
which is not reproducible and only works on x86_64.  Please make it not depend on
icedtea.
  * So does tepl, because it depends on gtksourceview
* libsecret fails two tests

libsecret test failure:
 9/12 test-item                               FAIL     0.87 s (killed by signal 11 SIGSEGV)
# GLib-DEBUG: posix_spawn avoided (workdir specified) (fd close requested) (child_setup specified) 
# GLib-DEBUG: setenv()/putenv() are not thread-safe and should not be used after threads are created
# GLib-DEBUG: unsetenv() is not thread-safe and should not be used after threads are created
[...]

 5/12 test-session                            FAIL     0.34 s (killed by signal 5 SIGTRAP)
# GLib-DEBUG: setenv()/putenv() are not thread-safe and should not be used after threads are created
Bail out! GLib-FATAL-CRITICAL: g_source_ref: assertion 'g_atomic_int_get (&source->ref_count) >= 0' failed
--- stderr ---

(test-session:406): GLib-CRITICAL **: 22:02:56.436: g_source_ref: assertion 'g_atomic_int_get (&source->ref_count) >= 0' failed

Both of those tests work fine outside nix build container and outside pure guix environment, while logged into X.

  * memphis doesn't build because of that
  * network-manager doesn't build because of that
  * gtksourceview doesn't build because of that
* gjs is not reproducible

gjs diffoscope:
├── bin
│ ├── .gjs-console-real
│ │ ├── readelf --wide --decompress --hex-dump=.data {}
│ │ │ @@ -51,15 +51,15 @@
│ │ │    0x0040a540 00000000 00000000 94ab4000 00000000 ..........@.....
│ │ │    0x0040a550 be714000 00000000 00000000 00000000 .q@.............
│ │ │    0x0040a560 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a570 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a580 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a590 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a5a0 2a353741 00000000 00000000 00000000 *57A............
│ │ │ -  0x0040a5b0 f3a04bb6 00000000 30754000 00000000 ..K.....0u@.....
│ │ │ +  0x0040a5b0 48ed49b6 00000000 30754000 00000000 H.I.....0u@.....
│ │ │    0x0040a5c0 00474000 00000000 00000000 00000000 .G@.............
│ │ │    0x0040a5d0 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a5e0 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a5f0 00000000 00000000 00000000 00000000 ................
│ │ │    0x0040a600 00000000 00000000 05000000 00000000 ................
│ │ │    0x0040a610 60a24000 00000000 00000000 00000000 `.@.............
│ │ │    0x0040a620 2a353741 00000000 00000000 00000000 *57A............
[...]
├── lib
│ ├── libgjs.so.0.0.0
│ │ ├── readelf --wide --decompress --hex-dump=.data {}
│ │ │ @@ -2687,15 +2687,15 @@
│ │ │    0x0049e4c0 a0223a00 00000000 00000000 00000000 .":.............
│ │ │    0x0049e4d0 00000000 00000000 00000000 00000000 ................
│ │ │    0x0049e4e0 40203a00 00000000 0c000000 00000000 @ :.............
│ │ │    0x0049e4f0 40000000 00000000 2cca3a00 00000000 @.......,.:.....
│ │ │    0x0049e500 a0223a00 00000000 00000000 00000000 .":.............
│ │ │    0x0049e510 00000000 00000000 00000000 00000000 ................
│ │ │    0x0049e520 2a353741 00000000 00000000 00000000 *57A............
│ │ │ -  0x0049e530 e9a54bb6 00000000 00413a00 00000000 ..K......A:.....
│ │ │ +  0x0049e530 00f249b6 00000000 00413a00 00000000 ..I......A:.....

  * network-manager doesn't build reproducibly because of that, and doesn't build at all because of the libsecret test failures
    * network-manager-applet doesn't build reproducibly because of that
  * tracker doesn't build reproducibly because of that
    * tracker-miners doesn't build reproducibly because of that

Pushed your patches to wip-desktop anyway.

Please fix libsecret.

The other things are nice-to-have for now, but should also be fixed
eventually.

Did I apply all the patches you sent me or are some still pending?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-08-03 22:30 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06  9:13 Raghav Gururajan
2020-05-06 14:19 ` Ludovic Courtès
2020-05-06 15:05   ` Gábor Boskovits
2020-05-06 15:49 ` Ricardo Wurmus
2020-05-06 16:03   ` Raghav Gururajan
2020-05-06 15:52 ` sirgazil
2020-05-06 16:04   ` Raghav Gururajan
2020-05-06 17:22 ` Jan Nieuwenhuizen
2020-05-06 17:23   ` Raghav Gururajan
2020-05-20 13:34 ` Raghav Gururajan
2020-05-20 13:51   ` Pierre Neidhardt
2020-05-20 13:57     ` Raghav Gururajan
2020-05-20 14:06       ` Pierre Neidhardt
2020-05-21  9:08   ` Efraim Flashner
2020-05-22 11:18     ` Raghav Gururajan
2020-05-22 11:25   ` Raghav Gururajan
2020-05-23 14:26     ` Raghav Gururajan
2020-05-25 20:08       ` Danny Milosavljevic
2020-05-28 17:11         ` Raghav Gururajan
2020-05-28 17:10       ` Raghav Gururajan
2020-05-28 18:23         ` Danny Milosavljevic
2020-05-29 21:01           ` Raghav Gururajan
2020-05-29 23:02             ` Danny Milosavljevic
2020-05-29 20:54         ` Raghav Gururajan
2020-05-29 21:08           ` Raghav Gururajan
2020-05-30 20:30             ` Raghav Gururajan
2020-05-31 13:31               ` Danny Milosavljevic
2020-06-10 13:12                 ` Raghav Gururajan
2020-06-04 18:31               ` Raghav Gururajan
2020-06-04 18:52                 ` Vincent Legoll
2020-06-10 13:06                   ` Raghav Gururajan
2020-06-04 18:57                 ` Danny Milosavljevic
2020-06-14 13:31                 ` Raghav Gururajan
2020-06-19 23:37                   ` Raghav Gururajan
2020-06-24 22:40                     ` Danny Milosavljevic
2020-07-04 10:37                       ` Raghav Gururajan
2020-07-04 11:14                         ` Raghav Gururajan
2020-07-06  1:36                           ` Raghav Gururajan
2020-07-06 19:24                           ` Danny Milosavljevic
2020-07-06 19:56                             ` Efraim Flashner
2020-07-05 19:25                         ` Danny Milosavljevic
2020-07-06  5:05                           ` Raghav Gururajan
2020-07-13 13:45                             ` Ludovic Courtès
2020-07-13 13:50                               ` Raghav Gururajan
2020-07-16  1:21                             ` Raghav Gururajan
2020-07-17 12:38                               ` Danny Milosavljevic
2020-07-18 13:29                                 ` Raghav Gururajan
2020-07-18 14:12                                   ` Danny Milosavljevic
2020-07-18 19:27                                     ` Raghav Gururajan
2020-07-18 20:18                                       ` Raghav Gururajan
2020-07-19 11:43                                         ` Danny Milosavljevic
2020-07-19 19:21                                         ` Danny Milosavljevic
2020-07-19 19:22                                   ` Danny Milosavljevic
2020-07-20  1:54                                     ` Raghav Gururajan
2020-07-24 18:29                                       ` Raghav Gururajan
2020-07-25  8:15                                         ` Raghav Gururajan
2020-07-25  8:18                                           ` Raghav Gururajan
2020-07-25  8:24                                             ` Raghav Gururajan
2020-07-25  9:12                                               ` Raghav Gururajan
2020-07-27 16:11                                                 ` Raghav Gururajan
2020-07-30 23:51                                                   ` Raghav Gururajan
2020-08-02  7:32                                                   ` Raghav Gururajan
2020-08-03 22:29                                                     ` Danny Milosavljevic [this message]
2020-08-04 10:22                                                       ` Raghav Gururajan
2020-08-04 22:50                                                         ` Raghav Gururajan
2020-08-05 15:14                                                           ` Danny Milosavljevic
2020-08-07  2:14                                                             ` Raghav Gururajan
2020-08-09 22:28                                                               ` Danny Milosavljevic
2020-08-11 10:38                                                                 ` Raghav Gururajan
2020-08-12  4:05                                                                   ` Raghav Gururajan
2020-08-12  4:11                                                                     ` Raghav Gururajan
2020-08-12  8:02                                                                       ` Danny Milosavljevic
2020-08-19 15:06                                                                         ` Raghav Gururajan
2020-08-22 14:48                                                                           ` Pierre Neidhardt
2020-08-24  3:18                                                                           ` Maxim Cournoyer
2020-08-14 14:24                                                               ` [20.08.2020 Hartmut Goebel
2020-08-14 14:28                                                                 ` [20.08.2020 Raghav Gururajan
2020-06-24 11:37                   ` [OUTREACHY]: Integration of desktop environments into GNU Guix Danny Milosavljevic
2020-06-25  4:04                     ` Raghav Gururajan
2020-06-25 11:47                       ` Danny Milosavljevic
2020-06-28  5:56                         ` Raghav Gururajan
2020-06-25 11:52                       ` Danny Milosavljevic
2020-05-25 19:58     ` Danny Milosavljevic
2020-05-25 20:00     ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804002921.39a351a1@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of guix-devel@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-devel/0 guix-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-devel guix-devel/ https://yhetil.org/guix-devel \
		guix-devel@gnu.org
	public-inbox-index guix-devel

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.devel
	nntp://news.gmane.io/gmane.comp.gnu.guix.devel


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git