unofficial mirror of guix-devel@gnu.org 
 help / color / Atom feed
From: Tanguy Le Carrour <tanguy@bioneland.org>
To: Marius Bakke <marius@gnu.org>
Cc: Guix <guix-devel@gnu.org>
Subject: Re: [PATCH 0/X] gnu: poetry: Fix broken dependency after dependency's version update.
Date: Thu, 30 Jul 2020 15:18:05 +0200
Message-ID: <20200730131805.f3lqoiszb456jx4y@rafflesia> (raw)
In-Reply-To: <875za6q6yt.fsf@gnu.org>

Hi Marius,


Le 07/30, Marius Bakke a écrit :
> Tanguy Le Carrour <tanguy@bioneland.org> writes:
> > Few days ago, I submitted a patch to update `python-tomlkit`. It was pushed
> > to master and, after I upgraded my packages today, I realised that `poetry`
> > (and possibly other python packages) was broken!
> >
> > The "problem" is that Poetry depends on `tomlkit = "^0.5.11"`. This
> > translates to `>=0.5.11,<0.6.0`. And I updated `python-tomlkit` to… 0.6.0!
> >
> > In SemVer [1], minor releases are supposed to "add functionality
> > in a backwards compatible manner", so this "<0.6.0" seems, IMHO, wrong.
> > But that's not the point…
> >
> > [1]: https://semver.org/
> >
> > Now, I have to fix Poetry and I have 2 options:
> > - modify poetry `setup.py` and substitute `>=0.5.11,<0.7.0` to `>=0.5.11,<0.6.0`;
> > - add a new `python-tomlkit-0.5` and use it in the propagated inputs.
> >
> > Any suggestion on the one I should implement?
> 
> I haven't looked into it, but if the tomlkit API really is compatible,
> the first suggestion sounds good to me.  It would be good to notify
> upstream about the unreasonable "pinning" in that case.

Problem reported upstream: <https://github.com/python-poetry/poetry/issues/2752>.


> Otherwise the second suggestion sounds good too.  There is plenty of
> precedence for both solutions in Guix and is really something that needs
> to be decided on a case-by-case basis.

I decided to implement the "quick fix": <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=42619>.
I'll implement the `python-tomlkit-0.5` solution if upstream does not
see this as a problem.

Regards

-- 
Tanguy


      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 15:48 Tanguy Le Carrour
2020-07-29 22:42 ` Marius Bakke
2020-07-30 13:18   ` Tanguy Le Carrour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730131805.f3lqoiszb456jx4y@rafflesia \
    --to=tanguy@bioneland.org \
    --cc=guix-devel@gnu.org \
    --cc=marius@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of guix-devel@gnu.org 

Archives are clonable:
	git clone --mirror https://yhetil.org/guix-devel/0 guix-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-devel guix-devel/ https://yhetil.org/guix-devel \
		guix-devel@gnu.org
	public-inbox-index guix-devel

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.devel
	nntp://news.gmane.io/gmane.comp.gnu.guix.devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git