Re: Jami bug source investigation #4

[Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>]

Hi,

On Sun, 05 Jul 2020 21:29:33 +0100
Christopher Baines <mail@cbaines.net> wrote:
> 
> So, I tried adding -DNDEBUG to the CFLAGS bit of the
> #:configure-flags, and the package built. Testing it out seems to
> work, I think I've experienced this issue with assertion failures, so
> hopefully this will help.
> 
> modified   gnu/packages/jami.scm
> @@ -141,7 +141,7 @@
>               ;; against pjproject-jami:
>               ;;   relocation R_X86_64_32S against `.rodata' can not
> be used when ;;   making a shared object;
> -             "CFLAGS=-fPIC"
> +             "CFLAGS=-fPIC -DNDEBUG"
>               "CXXFLAGS=-fPIC")
>         #:phases
>         (modify-phases %standard-phases
> 
> Is there more to applying this fix, or will this change alone help?
> I'm more than happy to review patches.
> 
> Thanks,
> 
> Chris

That's it for the bug, if you want to have it fixed quickly, feel free
to commit it. I didn't do it yet, because I'm busy writting commit
messages for my refactored and updated package definitions.
I'm also trying to catch up with the latest Jami version - they fixed
some annoying stuff too.

Is there a script for automatically writing commit messages compliant
with the GNU coding standards?


Jan Wielkiewicz