unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org
Subject: Re: Jami bug source investigation #4
Date: Mon, 22 Jun 2020 14:23:39 +0200	[thread overview]
Message-ID: <20200622142339.5889dc4e@kompiuter> (raw)
In-Reply-To: <87ftan368t.fsf@ambrevar.xyz>

On Mon, 22 Jun 2020 09:32:50 +0200
Pierre Neidhardt <mail@ambrevar.xyz> wrote:

> Great!  Does this fix any other issue?
> Does it warrant a package upgrade in Guix?
> 

This alone didn't fix the problem, but as no other possibility was left
than broken pjproject, I tried to fix it and succeeded.
It is mandatory to pass "-DNDBUG" flag to turn off assertion.
https://trac.pjsip.org/repos/wiki/FAQ#Performance
https://trac.pjsip.org/repos/wiki/FAQ#assert

"Release mode. Don't forget to set the appropriate compiler
optimization flag, and disable assertion with -DNDEBUG."

This surely fixes the bug the reason of I was chasing for several
months, where after disconnecting from audio call, the daemon
"crashed" (asserted).
It is also possible this fixes some other issues with SIP, I didn't
test, because I was uninterested.

I'll prepare my messy code for committing once I have more time.

I'm not sure whether I should fetch from git or use a tarball after
doing all this work. Fetching from git adds more complexity to the
packages, but it gives me more control over it plus I'm not sure if I
can trust the tarballs anymore, after two cases where some files/folders
were missing.

Once I'll send the patches, would be cool if someone tested it.



Jan Wielkiewicz


  reply	other threads:[~2020-06-22 12:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  0:35 Jami bug source investigation #4 Jan Wielkiewicz
2020-06-18  6:52 ` Pierre Neidhardt
2020-06-18 18:22   ` Jan
2020-06-19 23:21   ` Jan Wielkiewicz
2020-06-21  0:38   ` Jan Wielkiewicz
2020-06-22  7:32     ` Pierre Neidhardt
2020-06-22 12:23       ` Jan Wielkiewicz [this message]
2020-06-22 12:37         ` Pierre Neidhardt
2020-07-05 20:29         ` Christopher Baines
2020-07-06  0:30           ` Jan Wielkiewicz
2020-07-06  1:23           ` Jan Wielkiewicz
2020-07-06 15:52           ` Jan Wielkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200622142339.5889dc4e@kompiuter \
    --to=tona_kosmicznego_smiecia@interia.pl \
    --cc=guix-devel@gnu.org \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).