From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kJL6HtIB0F5EUAAA0tVLHw (envelope-from ) for ; Thu, 28 May 2020 18:24:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CNKcGtIB0F5WHwAAB5/wlQ (envelope-from ) for ; Thu, 28 May 2020 18:24:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3D8B19402A0 for ; Thu, 28 May 2020 18:24:18 +0000 (UTC) Received: from localhost ([::1]:57998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeNCT-0006JT-4A for larch@yhetil.org; Thu, 28 May 2020 14:24:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeNCI-0006I2-Oy for guix-devel@gnu.org; Thu, 28 May 2020 14:24:06 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:39034) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeNCG-0001b6-2b for guix-devel@gnu.org; Thu, 28 May 2020 14:24:06 -0400 Received: from localhost (80-110-127-207.cgn.dynamic.surfer.at [80.110.127.207]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 1B3DE336854B; Thu, 28 May 2020 20:24:01 +0200 (CEST) Date: Thu, 28 May 2020 20:23:59 +0200 From: Danny Milosavljevic To: Raghav Gururajan Subject: Re: [OUTREACHY]: Integration of desktop environments into GNU Guix Message-ID: <20200528202359.25c7b096@scratchpost.org> In-Reply-To: References: <20200506051334.4558e7b3.raghavgururajan@disroot.org> <8c56bfdd-4080-9444-d3c2-7bd962c4c687@disroot.org> <49cc7f39-7bce-f5a1-55da-5f9bca203627@disroot.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/=MMPzyvWeuRndanlr8LmW.Y"; protocol="application/pgp-signature"; micalg=pgp-sha512 Received-SPF: none client-ip=85.13.145.193; envelope-from=dannym@scratchpost.org; helo=dd26836.kasserver.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 14:24:01 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: LP+h+9JFgvn/ --Sig_/=MMPzyvWeuRndanlr8LmW.Y Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi RG, thanks for the patches! In my opinion, in patch 1 you are goading Guix to keep a reference to .../bin/true . coreutils is an implicit build input anyway, so no need to do that stuff. And if you do it, it looks as if you want it to keep a reference to coreuti= ls at runtime (it doesn't, but just saying). It looks more complicated, too. Please if you update the actual package from upstream, mention that fact in the commit log. If the actual upstream package changes, that's a serious change, right? People might wanna know where that happens. In patch 2 could have used rename-file instead of (copy; delete). What use is having a thing both propagated-input and regular input? (genuinely asking) Pushed to wip-desktop with minor changes (almost none of the above except for the (copy; delete) thing). --Sig_/=MMPzyvWeuRndanlr8LmW.Y Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl7QAb8ACgkQ5xo1VCww uqWNtwf/bHY0EjZ+/gS4HyuZTKyonLkC15dFDu1N5y7Xjwpei6dT7ubVH9gJ2JrN AOuHjbTEreEiaVsZTpCGl++JU49BXLIlMfxkIZz4f89wcH8JDpdlQ819C1lh8F9m WZhuuFsJlxeuZ2tzL2z42e1/ON8MGjZVwGdTGE0Kz5DVXMfoT8kRECur/xY6yMoa vxiERShtZ02ylccVjCHQAYLg0SyKRF/OT2gsYw1mkEcKxxO/TbTtfom4MvTFdpZZ d141Ye5a7DGoMESywszkfTE1kvAV5PCgTUCkioRl45o8CBvZYHNQkW4aA20W94ho My/A1VjLHaJEctNTYSj4UUAxr8HxvA== =daS6 -----END PGP SIGNATURE----- --Sig_/=MMPzyvWeuRndanlr8LmW.Y--