Re: branch master updated: gnu: gnome-todo: Fix build.

Re: branch master updated: gnu: gnome-todo: Fix build.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]

Hi Danny,

guix-commits@gnu.org writes:

> commit b17b29454d5edd61eecb4536461789b7a3865a9a
> Author: Danny Milosavljevic <dannym@scratchpost.org>
> AuthorDate: Wed May 6 17:36:03 2020 +0200
>
>     gnu: gnome-todo: Fix build.
>     
>     * gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch: New file.
>     * gnu/packages/gnome.scm (gnome-todo)[source]: Add it.
>     * gnu/local.mk (dist_patch_DATA): Add it.

Thanks for fixing GNOME Todo!

[...]

> diff --git a/gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch b/gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch
> new file mode 100644
> index 0000000..9e9c2e2
> --- /dev/null
> +++ b/gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch
> @@ -0,0 +1,7 @@
> +--- gnome-todo-3.28.1/plugins/eds/gtd-eds-autoptr.h.orig	2020-05-06 14:20:49.589902539 +0200
> ++++ gnome-todo-3.28.1/plugins/eds/gtd-eds-autoptr.h	2020-05-06 14:20:54.593919721 +0200
> +@@ -25,4 +25,3 @@
> + G_DEFINE_AUTOPTR_CLEANUP_FUNC (ECalComponent, g_object_unref);
> + G_DEFINE_AUTOPTR_CLEANUP_FUNC (ECalComponentId, e_cal_component_free_id);
> + G_DEFINE_AUTOPTR_CLEANUP_FUNC (ECalClient, g_object_unref);
> +-G_DEFINE_AUTOPTR_CLEANUP_FUNC (ESource, g_object_unref);

Can you add a short comment at the top of the patch file explaining what
this does, along with links to relevant upstream commits/issues (if
applicable)?

That way future packagers don't have to reverse-engineer your patch to
figure out what it does / whether it is still needed.

TIA!  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: branch master updated: gnu: gnome-todo: Fix build.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

Hi Marius,

On Wed, 06 May 2020 17:43:18 +0200
Marius Bakke <mbakke@fastmail.com> wrote:

> Can you add a short comment at the top of the patch file explaining what
> this does, along with links to relevant upstream commits/issues (if
> applicable)?

Whoops.

Sure.  Added in guix master commit 426adb4fc50cdfbc29fdc6ab6654956d0bc9f5c8.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]