From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: 01/02: build: gnu-build-system: Don't run configure during bootstrap. Date: Sun, 16 Feb 2020 18:48:29 +0200 Message-ID: <20200216164829.GF1968@E5400> References: <20200216072616.4957.58376@vcs0.savannah.gnu.org> <20200216072618.88AB021120@vcs0.savannah.gnu.org> <877e0m7gkn.fsf@devup.no> <20200216145517.GE1968@E5400> <20200216162422.GA5829@LionPure> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="B0nZA57HJSoPbsHY" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:46393) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3N6P-0006Jv-NH for guix-devel@gnu.org; Sun, 16 Feb 2020 11:49:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3N6L-0003YV-Da for guix-devel@gnu.org; Sun, 16 Feb 2020 11:49:05 -0500 Received: from flashner.co.il ([178.62.234.194]:34380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j3N6L-0003YB-6i for guix-devel@gnu.org; Sun, 16 Feb 2020 11:49:01 -0500 Content-Disposition: inline In-Reply-To: <20200216162422.GA5829@LionPure> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Bengt Richter Cc: guix-devel@gnu.org --B0nZA57HJSoPbsHY Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 16, 2020 at 05:24:22PM +0100, Bengt Richter wrote: > Hi Efraim, >=20 > On +2020-02-16 16:55:17 +0200, Efraim Flashner wrote: > > On Sun, Feb 16, 2020 at 03:27:36PM +0100, Marius Bakke wrote: > > > guix-commits@gnu.org writes: > > >=20 > > > > commit 481a0f1a7ceac666a011b28324220584ead07698 > > > > Author: Efraim Flashner > > > > AuthorDate: Thu Feb 13 10:54:29 2020 +0200 > > > > > > > > build: gnu-build-system: Don't run configure during bootstrap. > > > > =20 > > > > * guix/build/gnu-build-system.scm (bootstrap): Add NOCONFIGURE > > > > environment variable before running bootstrap scripts. > > >=20 > > > [...] > > >=20 > > > > @@ -190,6 +190,7 @@ working directory." > > > > (if (executable-file? script) > > > > (begin > > > > (patch-shebang script) > > > > + (setenv "NOCONFIGURE" "true") > > > > (invoke script)) > > > > (invoke "sh" script))) > > > > (if (or (file-exists? "configure.ac") > > >=20 > > > Should we unset NOCONFIGURE afterwards? Probably at least one package > > > uses this variable for something completely different... > >=20 > > It probably wouldn't hurt to unset it. I've never come across a package > > where that's been a problem but best not invite trouble. > > > With all due respect, I am not comfortable with this kind of rationale :)= =20 >=20 > If it's never been a problem, unsetting might hide a case where it _would_ > cause a problem -- which IMO it would be better to find out about than no= t. >=20 > Is there an official policy regarding garbage/dangling environment variab= les? >=20 > (Or is that just to be expected in the sargasso sea of "undefined behavio= ur"? ;-) >=20 > So, if in doubt, instead of unsetting, perhaps set it something like >=20 > "IF_YOU_SEE_THIS_PLEASE_REPORT_HOW_IT_HAPPENED_TO_efraim_AT_flashner.= co.il" >=20 > ;-P >=20 > or make it throw an exception somehow, if following processing uses NOCON= FIGURE > any way at all before being replaced with a proper meaningful new value. >=20 > > Also, looking at the snippet, I should move it higher up. If it's not > > executable then NOCONFIGURE doesn't get set. > >=20 >=20 > Hope I didn't offend anyone :) (ins)efraim@E5400 ~$ env | grep -i pants PANTS=3DON There's some inside joke somewhere in Enlightenment that I don't know. I've found the code that sets PANTS=3DON but I've never tried changing it. The beginning of the gnu-build-system goes: (phases set-SOURCE-DATE-EPOCH set-paths install-locale unpack bootstrap So if NOCONFIGURE is set previously it's from us anyway. So in this case I think it's fair to clean up after ourselves. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --B0nZA57HJSoPbsHY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5Jcl0ACgkQQarn3Mo9 g1GNmBAAsfXLFozSm6r7r6O4Erut71RCA62hyIyLlbD/t8yOsVZ00Th8mqW7tZI1 4fjgaskrxX3FBCo3Fqa9RD1XJ3S1oswMJjOtspllTh9Xiy3tqOQOLAd15/wiwtIe 6n/T9cy9Z9ViX17TRcv1yYCSfXmVC2zaq7oQJKwM7lRSXzwkE+nBSNpksDj8uz8n eKBUwd0Whw05rKJg7fziDcSNjMSt9zjtrHAF+2RjTW+sBGZE6gIOGncS8h/YKQVo cuffP1BhzUp4BxexW/53U1x+7SLMlMQUwqkIibpoZXKBRLIXHVL0KT3UpT2RZQ9u JwSNxeaW2bEQr0vNScnXPk6TXmnygGMViRjwzf3Qq7KpdHQiQBcUagQy5y/YprWG fy2XxGpWapnqyN0pYqyTvovgYpApBzd+2S2URsdeXDW5nyymHOKKTiiamWDiF92V WCA3iKlWh9n8wSFpLg5p3iHQhmho9v08a/R7EXI6HxqXy5fvq9kaoCrpKKQmwQUC pLQcIln0L6lHtUOw8tb4hMiuqybZp88Txzqi9EXQ620TTjhMPzdOfuNd+q89BjOv UurhnUXTscUZfS2w4vK+A7pYHT0DVynZE1qjBVG6gilcN77rca3IY9QIqDXQjA9+ deK5f+/zLSde5ue8uwOhSRqje/tqR02voQa1UVqmWlQH6Q7oZv4= =crIo -----END PGP SIGNATURE----- --B0nZA57HJSoPbsHY--