From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: rust-build-system: Unvendor *-sys libraries in phase? Date: Mon, 27 Jan 2020 18:36:06 +0200 Message-ID: <20200127163606.GS1603@E5400> References: <20200125184959.GM1603@E5400> <20200125193615.GO1603@E5400> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Lh1tzOZp3jg2TtWy" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:33637) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iw7Nu-0008UR-0G for guix-devel@gnu.org; Mon, 27 Jan 2020 11:37:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iw7Nt-000171-2Z for guix-devel@gnu.org; Mon, 27 Jan 2020 11:37:09 -0500 Received: from flashner.co.il ([178.62.234.194]:33080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iw7Ns-0000i3-SC for guix-devel@gnu.org; Mon, 27 Jan 2020 11:37:09 -0500 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: John Soo Cc: Guix-devel --Lh1tzOZp3jg2TtWy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 27, 2020 at 02:44:13PM +0000, John Soo wrote: > Hi Efraim, >=20 > > I didn't mean to actually fix it, but it seems that just eliminating > > directories is enough to make it work. > > > > I've attached a simple diff against cargo-build-system and rust-libz-sys > > and rust-libgit2-sys which removes the bundled source from both crates > > and builds rust-libgit2-sys without complaints. >=20 > This looks good. Can the phases doing the same thing in the arguments > of libgit, etc. be removed too? I have a set of patches locally to unbundle a bunch of the other -sys libraries and move the PKG_CONFIG environment variables to cargo-build-system. I'll go ahead and push them after I make sure the different packages build. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Lh1tzOZp3jg2TtWy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl4vEXMACgkQQarn3Mo9 g1ElOw/+I1ul32jh3fVeeLXCph5kalHXVwi3Mq2hEzHdt2DApod10Z6yiSYj5wXE M7L6tFmglfM6v3mo+MWjQr4nlZc9UwF8TQtmqDQ0z5ud6Dn5ppg427ykN/MkHGvd A0OxlUi6JqQvXZcHAGSylEmk21MgE75RkJAYbcEQy33G43wmPPd00ZWzLKK4m226 YYuS0UG3FgvlzBA8zVdPA34yv+A0SYVBml+dpZ3ju+L2dMBN2HM3WciLvSicS8JB wvPXsh2FuWnHTInlliL0CUqHSbHYrY9RDjwKJR/RSfaDP1OgTdhs7ES+hJpOTBM3 Nlc5T1tJpVe4rrlSkTl0DeDeeOwlVg62tWPdkI6+YtUQjz0gF6438paNMVYw4dGu jbiiUwmF5CJHfZqzwN4AvGx/O4DH44QQAXQkIlEC2XygbqMMdf8gicImZAgR5IpZ aETHMiOtW+hmZ67HzS8KTyybR32k3LvDriELMH9jb/xMGJ/fH+2AFPWWJ8s9MwwD R/d8a+SRUmg5pDIowOPLCdeSkiWRGI9apnqsfvffi5hYcvpyyhI+N1gGvCfScSWD O56WedJwTwIV4h1NStzZs0DKPQadeGHznY+hJ5vHCUB6czOYnEr/WcXla/of5qav sgpXG6ShUiEylzaSMTLmtG02mzCntc2UDazfzipGISWz5FkfKTQ= =T0xE -----END PGP SIGNATURE----- --Lh1tzOZp3jg2TtWy--