From: Efraim Flashner <efraim@flashner.co.il>
To: John Soo <jsoo1@asu.edu>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: rust-build-system: Unvendor *-sys libraries in phase?
Date: Mon, 27 Jan 2020 18:36:06 +0200 [thread overview]
Message-ID: <20200127163606.GS1603@E5400> (raw)
In-Reply-To: <CAKf5CqX2i_J3MvCroJqCt=hETuMx9-t3R8T6r9KeJq7fn2sfsw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On Mon, Jan 27, 2020 at 02:44:13PM +0000, John Soo wrote:
> Hi Efraim,
>
> > I didn't mean to actually fix it, but it seems that just eliminating
> > directories is enough to make it work.
> >
> > I've attached a simple diff against cargo-build-system and rust-libz-sys
> > and rust-libgit2-sys which removes the bundled source from both crates
> > and builds rust-libgit2-sys without complaints.
>
> This looks good. Can the phases doing the same thing in the arguments
> of libgit, etc. be removed too?
I have a set of patches locally to unbundle a bunch of the other -sys
libraries and move the PKG_CONFIG environment variables to
cargo-build-system. I'll go ahead and push them after I make sure the
different packages build.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-01-27 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 21:49 rust-build-system: Unvendor *-sys libraries in phase? John Soo
2020-01-25 18:49 ` Efraim Flashner
2020-01-25 19:01 ` John Soo
2020-01-25 19:36 ` Efraim Flashner
2020-01-27 14:44 ` John Soo
2020-01-27 16:36 ` Efraim Flashner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127163606.GS1603@E5400 \
--to=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
--cc=jsoo1@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).