From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: (not) testing Rust packages?! Date: Sat, 25 Jan 2020 20:55:46 +0200 Message-ID: <20200125185546.GN1603@E5400> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="K4LMwn8CgX2KMboP" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:34257) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivQbT-0004c8-S9 for guix-devel@gnu.org; Sat, 25 Jan 2020 13:56:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivQbS-0007mu-TT for guix-devel@gnu.org; Sat, 25 Jan 2020 13:56:19 -0500 Received: from flashner.co.il ([178.62.234.194]:56678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ivQbS-0007kg-Mu for guix-devel@gnu.org; Sat, 25 Jan 2020 13:56:18 -0500 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: John Soo Cc: guix-devel@gnu.org --K4LMwn8CgX2KMboP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 25, 2020 at 08:46:48AM -0800, John Soo wrote: > Hi Hartmut and Martin, >=20 > I think it makes sense to run tests now. >=20 > > Part of the reason is that bringing tests for a given library can bring= in a massive amount of dependencies. >=20 > I think that we are getting close to having complete dependencies for mos= t rust packages we have and most are declared in the package definition.=20 >=20 > Furthermore since most rust libraries we have are not executables, we cou= ld still skip the build and run the tests I think. Aren=E2=80=99t the two p= hases completely separate for cargo? >=20 > Other downsides I see for not skipping the build are really increasing th= e store size. Would skipping builds but still running tests increase the s= tore size at all? >=20 > I like the idea of having tests, too. Plus I=E2=80=99d like to see the c= argo build system come closer to the standard package definition. >=20 In addition, since we don't actually need any of the results of the crates, it does provide a quick way to notice if we've provided the wrong version of a dependency. I also noticed that we're missing rust-average-0.9 which is definitely needed for rust-rand-0.6 and I'm sure others. If we enable building and tests and are lenient with skipping tests, that alone would be an improvement. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --K4LMwn8CgX2KMboP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl4sjzEACgkQQarn3Mo9 g1E3bQ//fvH7EtvdkCRdTS34oXK8PeUE5GfxgtV2z8QB0dy6SHTc+gkK9AuigfWZ u0aiX7hCNykkcwPcftTvWPDP1MMiLttDvB8eu7oD+NyoiJjWrFdwX1uf44e7e0aJ gbdEuWyD2BR8rEoi/+Psml4+y/yIQH8j6KLcd9McbBTP3vJOD/YeDnN1VDp9sC3g 0nwgffiklX4NBXunDlsANjjN5lbsde6UsKjZPSsh7hMZamlYzixAcuk/hGRpg2pA PasGhwcbv7x3vnjdNATK14EstowjEoXvOhkjbkyhz+rbYxvea31K67yvlKpefjMc 6xi/3+UiG07PbWKpf+247oay+QeWzHTqXs7XHdQZ+9nqK5w5fwcBozmKWpotT4pe eFXlf21/gXR2eFXHIT5TYGtFE8Nk3Xw/mkI/I9tlnnmJknYqteQIa4qwPYpoJ51T oRKIbIbMZme4EmNqTnXQlUO4ntgZTjq4mV8zoQTo+BeQ649V+0psQrEWPV7k5stQ Cel4McmWdGwzgf2mn/GQh+sdJdL9Qci+djN0Hh+kip/hfQwZsfGNnrEJGUKe4X4R D8WUGSH1QxS8lMR7zb74YeCgpUSAGazA6rAqHVHIm/+cmj74Mq9KvgqFm8MOTQvq 13fLZ4mp3ExpmYGMU7XtStI5hr3beCDVB5HYe/MMbsalmSdnIKQ= =D0eW -----END PGP SIGNATURE----- --K4LMwn8CgX2KMboP--