From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Wielkiewicz Subject: Re: Packaging Jami progress Date: Sun, 22 Dec 2019 00:28:15 +0100 Message-ID: <20191222002815.4db8e9ca@interia.pl> References: <20191215211230.66fea79e@interia.pl> <875zihclep.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:35211) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iioAg-0007tN-N6 for guix-devel@gnu.org; Sat, 21 Dec 2019 18:28:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iioAf-0000gd-Gz for guix-devel@gnu.org; Sat, 21 Dec 2019 18:28:30 -0500 Received: from smtpo.poczta.interia.pl ([217.74.65.233]:47437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iioAd-0000cU-BF for guix-devel@gnu.org; Sat, 21 Dec 2019 18:28:27 -0500 In-Reply-To: <875zihclep.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org Dnia 2019-12-15, o godz. 22:46:06 Ricardo Wurmus napisa=C5=82(a): > The test appears to compare the hash of this file with the hash of a > known good file. What are the contents? Can we adjust the test to > test for what is actually of interest here? >=20 > Otherwise it should be fine to disable it. >=20 Okay, I haven't got any answer from the devs so far and I'm looking for a way of disabling only the test that fails. I tried to use substitute* to remove=20 "include $(SRC_PATH)/tests/fate/lavf-container.mak" from the tests/Makefile, but it didn't work (don't know why) and tried removing "FATE_LAVF_CONTAINER-$(call ENCDEC2, MPEG4, PCM_ALAW, MOV) +=3D mov mov_rtphint ismv"=20 and "fate-lavf-mov_rtphint: CMD =3D lavf_container "" "-movflags +rtphint -c:a pcm_alaw -c:v mpeg4 -threads 1 -f mov"" from the "tests/fate/lavf-container.mak" file. The fragment of code I wrote looks like this: (add-before 'check 'skip-test (lambda _ (substitute* "tests/Makefile" (("include $(SRC_PATH)/tests/fate/lavf-container.mak") "")) #t)) I also made the git checkout writeable. Am I doing something wrong? Should I try deleting the test using snippet or just skip all tests using #:tests? #f? Jan Wielkiewicz