From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] WIP patches for the rust importer Date: Thu, 28 Nov 2019 14:22:55 +0200 Message-ID: <20191128122255.GT1124@E5400> References: <20191126120408.GL1124@E5400> <1E01C051-2EE5-4050-B826-C60E858AAC2B@flashner.co.il> <0b2db52d687fc2acf34dc1e00618dae7.squirrel@sm.riseup.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2MC+DK0smzICZJ/6" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:45379) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaIpd-0004HU-Qg for guix-devel@gnu.org; Thu, 28 Nov 2019 07:23:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaIpV-0005Wu-Mt for guix-devel@gnu.org; Thu, 28 Nov 2019 07:23:33 -0500 Received: from flashner.co.il ([178.62.234.194]:57520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iaIpV-0005Q9-De for guix-devel@gnu.org; Thu, 28 Nov 2019 07:23:29 -0500 Content-Disposition: inline In-Reply-To: <0b2db52d687fc2acf34dc1e00618dae7.squirrel@sm.riseup.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: mjbecze@riseup.net Cc: guix-devel@gnu.org --2MC+DK0smzICZJ/6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 27, 2019 at 04:36:20PM -0800, mjbecze@riseup.net wrote: >=20 > > I'd love to see what you have so far if you want to share >=20 > Okie Dokie, I posted it and cc'd ya. >=20 > Also I took a look at your patches. > 0001-import-crate-Don-t-include-optional-dependencies.patch should work > just fine with my patch. But > 0003-import-crate-Honor-versioned-dependencies-when-impor.patch will not > work. >=20 > I took a different route here with the naming. If you are interested take > a look take a look at my second patch. (recusive-import-semver) only will > add the version number to the name if the crate being imported is not the > latest version. I thought this was more inline with the canonical names, > but if always adding version number the export symbol is desirable it will > simplify things. >=20 I'll take a look at it in a minute. I figured with the versioned requirements we would always want to be specific in version numbers for crate dependents so I figured it made sense. Also, if we did want to provide an unversioned '-latest' version we could declare an extra variable '(define-public rust-libc rust-libc-0.2)' and now rust-libc points to rust-libc-0.2. > Also I added a function (find-packages-by-name*/direct) to packages.scm > which will return the export symbol of a package that already exists. I > use this in case there are some non-canocal export name already added. >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --2MC+DK0smzICZJ/6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl3fvBsACgkQQarn3Mo9 g1HpURAAwY1OR0+ws2QAj258GS3uUkMIZuwQ5XlUwUChjz88DBvtkAHCCQ2pER54 IMapGnbnXyeOMtvNj8koQ3XbHRZrHkRLpmEONQcqw+ROKDTsIG/nIFBwvLWwot8E wB3FlKiXIeAdBHEG1RkxF/spvgOI4PjWKMEjQsow0+1opaD6OeISfbbtIjzD5HjI jP0svnsbUW2B8REZzDnr9wOH7zLO8oq7FLBI6pHoiybeel/rrT6kKsv22Hxh6zQD G+672DX+x+aHIwlT00/0eF9keVOVUU1Ezv6Bbzp843L2cubpCjxwLfMvs/wFOYWQ qQ0Ez0bL7agsAPli/4wzEB3/WMdnAKMbYAZrSINHuANwml8FK0uSWBAcAE8JOiSd DubDK5odUXK91siA6kzLEo5Oii8ufrWsO5xmVWm0XQYzbM4q24YHW5nU64YIGVLA oePWTWCeqYA+88ofWXZ2+9g9+nz3SXrv3tSFUpiIiM0rLUW8LzjSkNydMEjwdkfP IUFs0wR4Avvh2oFBPJ73sGHcnhk350x7N2iKGl/ho1pMf70QpQdPgqkwP8sSXdDC B7DBW12uvKuXpGU5zrXespWRVI5yC+VO8lOboOQ/P0VlSthbDH62yAI/ZICAX0Or HPTHosXBG3gt5m5A740yrhcZC05by4kug+4oQr3eIyQPLhaVrig= =8I0P -----END PGP SIGNATURE----- --2MC+DK0smzICZJ/6--