Re: [PATCH] WIP patches for the rust importer

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]

On Wed, Nov 27, 2019 at 04:36:20PM -0800, mjbecze@riseup.net wrote:
> 
> > I'd love to see what you have so far if you want to share
> 
> Okie Dokie, I posted it and cc'd ya.
> 
> Also I took a look at your patches.
> 0001-import-crate-Don-t-include-optional-dependencies.patch should work
> just fine with my patch. But
> 0003-import-crate-Honor-versioned-dependencies-when-impor.patch will not
> work.
> 
> I took a different route here with the naming. If you are interested take
> a look take a look at my second patch. (recusive-import-semver) only will
> add the version number to the name if the crate being imported is not the
> latest version. I thought this was more inline with the canonical names,
> but if always adding version number the export symbol is desirable it will
> simplify things.
> 

I'll take a look at it in a minute. I figured with the versioned
requirements we would always want to be specific in version numbers for
crate dependents so I figured it made sense. Also, if we did want to
provide an unversioned '-latest' version we could declare an extra
variable '(define-public rust-libc rust-libc-0.2)' and now rust-libc
points to rust-libc-0.2.

> Also I added a function (find-packages-by-name*/direct) to packages.scm
> which will return the export symbol of a package that already exists. I
> use this in case there are some non-canocal export name already added.
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]