From: Miguel Arruga Vivas <rosen644835@gmail.com>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: guix-devel@gnu.org
Subject: Re: 'core-updates' Q4 2019
Date: Fri, 8 Nov 2019 01:58:24 +0100 [thread overview]
Message-ID: <20191108015824.6fa80912@gmail.com> (raw)
In-Reply-To: <87y2wtx5b6.fsf@posteo.net>
Hi Kei,
Kei Kebreau <kkebreau@posteo.net> writes:
> Miguel Arruga Vivas <rosen644835@gmail.com> writes:
> Boot and login worked properly for me after I cleared the contents of
> my /var/lib/gdm directory (if it's unclear why that directory
> matters, see
> https://lists.gnu.org/archive/html/guix-devel/2019-10/msg00421.html
> for a quick overview).
Great pointer, thank you, and good that it's solved.
> > - The patch for gedit contains a reference to libgd, wouldn't it be
> > clearer for the reader/updater to have it defined in a let over
> > the package definition and use the name in native-inputs?
> >
>
> I'm not sure. I don't know if there is an explicit convention for
> packaging software that is distributed like this, and the examples of
> this in the code base (that I've seen, at least) define the
> third-party library the way I've done it here. I'm open to change on
> this point though.
This actually should have been an open question, as I have a patch on
libosinfo, related with gnome-boxes (patches coming soon) and it
doesn't feel right for me having usb.ids and pci.ids hidden there, so
I've put another origin needed (osinfo-db) out there.
> > - Is there any reason to not patch-out the gtk-icon-update-cache
> > invocations? If I understand it correctly, this is performed at
> > profile level, so makes no sense creating a cache at package
> > level, isn't it? The patches for quadrapassel, gnome-klotski, ghex,
> > gnome-sudoku, gnome-mines, five-or-more and gedit contain
> > references to it. Maybe creating a package like
> > xorg-server-for-tests (perhaps 'gtk-bin-for-build'?) linked to
> > "true" from coreutils would help in the long term.
> >
>
> I don't think such a reason exists. I could add changes that
> substitute calls to "gtk-icon-update-cache" with "true" for these
> packages, but I agree that a better solution may be possible.
> Perhaps not a package; maybe a new 'patch-gtk-icon-update-cache'
> phase in the relevant build systems?
Some of these packages already have phases for it on master. I rebased
your branch onto it (1a9df94cec..fb936351d3), I had to solve two merge
conflicts: devhelp and totem.
devhelp's patch has only a trivial conflict, as there was no arguments
parameter before. OTOH, I did not check as much as I should totem's
last day, as now I have one question here: Who kills the Xvfb server
on display :1 after the tests? I see it's a common idiom, but I don't
get why shouldn't the daemon treat it like from any other process and
wait for it to reach completion (other than technical means, I mean).
This could be a great place for a #:xorg-for-tests?, should I try?
> > As a final comment, the gnome release cycle and the amount of
> > packages involved is quite big, so again, thank you.
> >
> > Happy hacking!
> > Miguel
>
> Thanks Miguel! This comment and review means a lot!
> Kei
Thank you too
Best regards,
Miguel
next prev parent reply other threads:[~2019-11-08 0:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 21:55 'core-updates' Q4 2019 Marius Bakke
2019-10-09 11:53 ` Mathieu Othacehe
2019-10-10 14:32 ` Ludovic Courtès
2019-10-10 15:35 ` Mathieu Othacehe
2019-10-10 21:22 ` Svante Signell
2019-10-11 7:52 ` Ludovic Courtès
2019-10-11 20:42 ` Kei Kebreau
2019-10-12 22:15 ` Ludovic Courtès
2019-10-15 1:28 ` Kei Kebreau
2019-10-15 16:49 ` Marius Bakke
2019-10-17 20:44 ` Kei Kebreau
2019-10-17 21:29 ` Ricardo Wurmus
2019-10-18 1:53 ` Kei Kebreau
2019-10-18 3:08 ` Ricardo Wurmus
2019-10-19 13:34 ` Timothy Sample
2019-10-20 3:29 ` Kei Kebreau
2019-10-21 13:58 ` pelzflorian (Florian Pelz)
2019-10-22 0:37 ` Timothy Sample
2019-10-23 3:07 ` Timothy Sample
2019-10-23 7:49 ` pelzflorian (Florian Pelz)
2019-10-26 20:26 ` Kei Kebreau
2019-10-23 17:49 ` Marius Bakke
2019-10-24 2:07 ` Timothy Sample
2019-10-24 18:17 ` Marius Bakke
2019-10-26 21:25 ` Timothy Sample
2019-11-02 2:27 ` Kei Kebreau
2019-11-04 19:37 ` Miguel Arruga Vivas
2019-11-05 23:38 ` Kei Kebreau
2019-11-06 17:46 ` Leo Famulari
2019-11-07 1:16 ` Kei Kebreau
2019-11-07 2:58 ` Timothy Sample
2019-11-08 0:58 ` Miguel Arruga Vivas [this message]
2019-11-23 2:11 ` Kei Kebreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108015824.6fa80912@gmail.com \
--to=rosen644835@gmail.com \
--cc=guix-devel@gnu.org \
--cc=kkebreau@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).