From mboxrd@z Thu Jan 1 00:00:00 1970 From: "pelzflorian (Florian Pelz)" Subject: Re: We need your feedback of the documentation videos! Date: Fri, 25 Oct 2019 23:58:04 +0200 Message-ID: <20191025215804.mevbuyvffpunyhbi@pelzflorian.localdomain> References: <20191017043403.hwv77ripwbrzco54@pelzflorian.localdomain> <8736fov6go.fsf@gnu.org> <20191019210034.elopd6mhzq2dinxl@pelzflorian.localdomain> <20191022120504.7cyoc5x2exylpzrg@pelzflorian.localdomain> <16df4499bf6.d6659b0f22661.6695205596769599213@zoho.com> <20191022185940.dvpzwtso6cvdq5yf@pelzflorian.localdomain> <20191025063559.7ok3gvrybrnb6na5@pelzflorian.localdomain> <87imoco9bb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:43517) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iO7ay-0000om-Rx for guix-devel@gnu.org; Fri, 25 Oct 2019 17:58:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iO7ax-0000GJ-B3 for guix-devel@gnu.org; Fri, 25 Oct 2019 17:58:08 -0400 Content-Disposition: inline In-Reply-To: <87imoco9bb.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Guix-devel Thank you for all your reviews! Feel free to change some things later on= : I will push tomorrow morning with a clear mind. :) On Tue, Oct 22, 2019 at 11:25:27AM -0500, sirgazil wrote: > Now, personally, if I had the time, I would have designed the videos pa= ge in a similar way to the blog page, I have *not* done this, only the link is no longer yellow. > and also done something like this: >=20 > [=E2=80=A6] > * Add a "media" app that would hold the definitions for videos and scre= enshots (the latter would move from the base app). I have done this, but most of the screenshot-related CSS remains in website/static/base/css/index.css. > [=E2=80=A6] > * Add a new entry to the Help page, next to "GNU Guix Manual", with the= same "Instructional videos" title. I have *not* done this yet, as I am bad at drawing icons for the help page. I could ask a friend of mine or have you do it. > > P.S. I would like to request a review of this functions I would like= =20 > > to add to website/apps/aux/lists.scm:=20 >=20 >=20 > Or maybe you could factor out the "sample" procedure defined in the > "index-builder" of "(apps packages builder)". I think Wurmus added > that one for the Packages home page. >=20 >=20 Thank you for the suggestion! However, I believe it would sample the same element twice. That is unlikely to happen for packages but a problem for screenshots. I will probably retain my take-random procedure, even though it is not as concise as it should be. > > Also I want to ask, the =E2=80=9Clicense=E2=80=9D header says:=20 > > =20 > > ;;; GNU Guix web site=20 > > ;;; Initially written by sirgazil who waves all=20 > > ;;; copyright interest on this file.=20 > > =20 > > sirgazil, shall I replace =E2=80=9Cwaves=E2=80=9D by =E2=80=9Cwaives= =E2=80=9D? I believe this is a=20 > > typo.=20 >=20 >=20 > That's a typo, yes. Although, if I didn't do anything in that file, > I think that line should not be there, but I'm not a lawyer. > IANAL, but I copied code from the files you worked on, so you have copyright. I will fix the typo in all files then. On Fri, Oct 25, 2019 at 10:32:24PM +0200, Ludovic Court=C3=A8s wrote: > "pelzflorian (Florian Pelz)" skribis: > > Ludo, shall I push this evening > > with videos coming from the Internet Archive (archive.org)? >=20 > Sure! I haven=E2=80=99t tried building the web site with the patches (= do check > =E2=80=9Cguix build -f .guix.scm=E2=80=9D before pushing), but the chan= ges LGTM > overall, and long overdue! >=20 > We can keep the videos on archive.org for now, I guess they won=E2=80=99= t > disappear overnight, and eventually we can move them to guix.gnu.org > when one of us can allocate time for that. >=20 > Thank you for moving forward on this topic! >=20 OK, thank you! Regards, Florian