From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: Cuirass enhancements Date: Wed, 19 Jun 2019 18:07:31 +0200 Message-ID: <20190619180731.1eaf1ed6@scratchpost.org> References: <20190618195025.62b32955@alma-ubu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/QkZ+bz6BQ/i6TG_JtTqK/39"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:54246) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdd7h-00013u-QB for guix-devel@gnu.org; Wed, 19 Jun 2019 12:07:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdd7g-0005AA-Dh for guix-devel@gnu.org; Wed, 19 Jun 2019 12:07:45 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:42276) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hdd7g-0004tB-2B for guix-devel@gnu.org; Wed, 19 Jun 2019 12:07:44 -0400 In-Reply-To: <20190618195025.62b32955@alma-ubu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?ISO-8859-1?Q?Bj=F6rn_H=F6fling?= Cc: guix-devel , Ricardo Wurmus --Sig_/QkZ+bz6BQ/i6TG_JtTqK/39 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Bj=C3=B6rn, On Tue, 18 Jun 2019 19:50:25 +0200 Bj=C3=B6rn H=C3=B6fling wrote: > * I would like to know that I'm on page k/n. That web interface is a frontend to a dynamically changing database (and a quickly changing database at that). What would "page" even mean there? And the "/n" part is impossible to keep constant because the database chang= es and so does n. So the "/n" part on the display would keep changing--and it would be correct in doing so. Furthermore, the page number you are *on* would also keep changing. Even if there were fixed-layout "page"s, the way the database is structured means that having pagination show a fixed number of items per page at all is difficult to do (cuirass tries to do it). Alternatively, the server could keep a serializable transaction open per client session. Then you just wouldn't see new builds until you somehow restarted your client session (HTTP is stateless--so more fakery necessary there). Then you can have page numbers :) > I'm at the first tab. "Previous" is greyed out. I don't like this graying out business. It's perfectly possible that a new entry appeared in the database that is now (because of the sorting) before = what you thought was the first page (because back then when you queried the page= it *was* the first page--emphasis on "was")--and now you can't get to it. > Then I would expect > "First" also to be greyed out: If I cannot go any further back, I am on > the "First" tab (linear, consecutive order of tabs assumed :-)) I've made "First" and "Last" behave the way you expect in cuirass commit d5b827097b456100039370003899ec7ad04ac934. However, that is not an endorsement of graying out. I just like consistency. =20 > Even worse at the end: I can click four times on "Next", and then be at > a page that shows only three jobs (the total number of jobs is not > always dividable by the number of jobs per page, so the last page > usually has a smaller remainder to show): > https://ci.guix.gnu.org/eval/5862?border-high-time=3D1560816540&border-hi= gh-id=3D1398862 > So, I cannot go any NEXTer, that button is greyed out. As with the > beginning, I'm expecting to be already on the LAST page. But the button > is clickable. And when I click it, I will receive a FULL PAGE!=20 Yeah, well, pages don't exist and cuirass in imperfectly faking them. I'd go back to first principles and ask what problem the paging is supposed= to solve, then solve it in a different way. It's already very different to wh= at book pages would be. Suggestions welcome. --Sig_/QkZ+bz6BQ/i6TG_JtTqK/39 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl0KXcMACgkQ5xo1VCww uqWtKQf+J4kTk5SI1B4QugyzRTc4M0o+w3c7Q8gOZHuXy9VghyGVy8ND8LA3zMWK Bum/gqgC7NhOx/xTcsIRNiBnBC1VB0163Bgc/v1qIa8FuPiw26kuVdhIX4lPabt2 YekstGc8rFKV+2WWEn4vdfGIyRDTwsPoZ0/cUn78dejV6fNe1X8UEbVowz2R0Pbf 9kA7YHVH6LGNaDbRapaljAWtqCw5jmdSRvOcQAQwY5JkttGilcLZ5tbsZgCy/1HN UvaDf+6eqdy1XKFtF2ipwygJTb9A+UApQnB36ulbLD13f+RCcCFh8HCFbnufFcWG 1tPJRhD8GKZqofKhIfnid63RIVI/Fw== =6IP8 -----END PGP SIGNATURE----- --Sig_/QkZ+bz6BQ/i6TG_JtTqK/39--