guile-bash updated source url

guile-bash updated source url

[david.larsson]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

Hello Guix,

This is my first contribution to guix and it's just a minor fix for
the guile-bash package which had an outdated source url. I was able to
retrieve the same revision of the package via the software-heritage
project's website and upload it to gitlab. Then I installed it
successfully via guix package -f my-guile-bash.scm using the gitlab url, 
then copied it to the existing guile-xyz.scm in gnu/packages.

I have attached a patch-file with the changes.

--
Best Regards
David L

[-- Attachment #2: Type: text/plain, Size: 1837 bytes --]

From 75f8252f2c27f04961445f898041dd3f8a552e8a Mon Sep 17 00:00:00 2001
From: David Larsson <david.larsson@selfhosted.xyz>
Date: Sun, 28 Apr 2019 10:05:39 +0200
Subject: [PATCH] Updated source url for guile-bash package

---
 gnu/packages/guile-xyz.scm | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 03fd63837e..8f341be781 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -294,23 +294,21 @@ dictionary and suggesting spelling corrections.")
     (license license:gpl3+)))
 
 (define-public guile-bash
-  ;; This project is currently retired.  It was initially announced here:
-  ;; <https://lists.gnu.org/archive/html/guile-user/2015-02/msg00003.html>.
-  (let ((commit "1eabc563ca5692b3e08d84f1f0e6fd2283284469")
+    (let ((commit "49099fe6a592aa3b8001e826b939869fe5811785")
         (revision "0"))
     (package
       (name "guile-bash")
       (version (string-append "0.1.6-" revision "." (string-take commit 7)))
       (home-page
-       "https://anonscm.debian.org/cgit/users/kaction-guest/retired/dev.guile-bash.git")
+       "https://gitlab.com/methuselah-0/guile-bash")
       (source (origin
                 (method git-fetch)
                 (uri (git-reference
                       (commit commit)
-                      (url home-page)))
+		      (url "https://gitlab.com/methuselah-0/guile-bash.git")))
                 (sha256
                  (base32
-                  "097vny990wp2qpjij6a5a5gwc6fxzg5wk56inhy18iki5v6pif1p"))
+                  "1cwyf7sd0chrfmfipkvaph5gf70hck6fj36sxcc4ncin49xlxv0l"))
                 (file-name (string-append name "-" version "-checkout"))))
       (build-system gnu-build-system)
       (arguments
-- 
2.20.1

Re: guile-bash updated source url

[Andreas Enge]

Hello,

On Sun, Apr 28, 2019 at 10:28:43AM +0200, david.larsson@selfhosted.xyz wrote:
> This is my first contribution to guix and it's just a minor fix for
> the guile-bash package which had an outdated source url. I was able to
> retrieve the same revision of the package via the software-heritage
> project's website and upload it to gitlab. Then I installed it
> successfully via guix package -f my-guile-bash.scm using the gitlab url,
> then copied it to the existing guile-xyz.scm in gnu/packages.
> I have attached a patch-file with the changes.

should the package not be retrieved automatically from Software Heritage
with the newest Guix API? And apart from that, will it be desirable to keep
around an unmaintained software for which the source has disappeared?

Andreas

Re: guile-bash updated source url

[Ludovic Courtès]

Hello David,

david.larsson@selfhosted.xyz skribis:

> This is my first contribution to guix and it's just a minor fix for
> the guile-bash package which had an outdated source url. I was able to
> retrieve the same revision of the package via the software-heritage
> project's website and upload it to gitlab. Then I installed it
> successfully via guix package -f my-guile-bash.scm using the gitlab
> url, then copied it to the existing guile-xyz.scm in gnu/packages.

[...]

> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -294,23 +294,21 @@ dictionary and suggesting spelling corrections.")
>      (license license:gpl3+)))
>  
>  (define-public guile-bash
> -  ;; This project is currently retired.  It was initially announced here:
> -  ;; <https://lists.gnu.org/archive/html/guile-user/2015-02/msg00003.html>.
> -  (let ((commit "1eabc563ca5692b3e08d84f1f0e6fd2283284469")
> +    (let ((commit "49099fe6a592aa3b8001e826b939869fe5811785")
>          (revision "0"))

Why is the commit different?  Looks like it’s more than just a mirror.

If you made changes on top of the original code, that’s actually great.
However, I’d prefer to first see a patch that simply changes the URL,
not the commit and hash, and later updates to a different revision.

Does that make sense?

Andreas Enge <andreas@enge.fr> skribis:

> should the package not be retrieved automatically from Software Heritage
> with the newest Guix API? And apart from that, will it be desirable to keep
> around an unmaintained software for which the source has disappeared?

I think David is in fact suggesting that they may well be maintaining
it, which is good news IMO.  :-)

Thanks,
Ludo’.

Re: guile-bash updated source url

[david.larsson]

[-- Attachment #1: Type: text/plain, Size: 2980 bytes --]

Hi Andreas & Ludo,

On Fri, 3 May 2019, Ludovic Courtès wrote:

> Hello David,
>
> david.larsson@selfhosted.xyz skribis:
>
>> This is my first contribution to guix and it's just a minor fix for
>> the guile-bash package which had an outdated source url. I was able to
>> retrieve the same revision of the package via the software-heritage
>> project's website and upload it to gitlab. Then I installed it
>> successfully via guix package -f my-guile-bash.scm using the gitlab
>> url, then copied it to the existing guile-xyz.scm in gnu/packages.
>
> [...]
>
>> --- a/gnu/packages/guile-xyz.scm
>> +++ b/gnu/packages/guile-xyz.scm
>> @@ -294,23 +294,21 @@ dictionary and suggesting spelling corrections.")
>>      (license license:gpl3+)))
>>
>>  (define-public guile-bash
>> -  ;; This project is currently retired.  It was initially announced here:
>> -  ;; <https://lists.gnu.org/archive/html/guile-user/2015-02/msg00003.html>.
>> -  (let ((commit "1eabc563ca5692b3e08d84f1f0e6fd2283284469")
>> +    (let ((commit "49099fe6a592aa3b8001e826b939869fe5811785")
>>          (revision "0"))
>
> Why is the commit different?  Looks like it’s more than just a mirror.
>
> If you made changes on top of the original code, that’s actually great.
> However, I’d prefer to first see a patch that simply changes the URL,
> not the commit and hash, and later updates to a different revision.
>
> Does that make sense?
>

I made a commit since I was unable figure out how to create a
git-mirror from the Software Heritage website but was able to retrieve
the correct commit as a tarball. Then I guix init'ed the folder, and
made a commit in order to push it to gitlab.

> Andreas Enge <andreas@enge.fr> skribis:
>
>> should the package not be retrieved automatically from Software Heritage
>> with the newest Guix API? And apart from that, will it be desirable to keep
>> around an unmaintained software for which the source has disappeared?

I don't know if the newest Guix API would fix it, but I haven't been
able to install guile-bash from source so far using e.g. guix
challenge. I can't really answer your second question, but I will
personally use the package and thought it would be nice to be able to
retrieve it from a standard Guix install and that it can be built and
challenged. Previously I had to add additional --substitute-url's to
guix install it.

>
> I think David is in fact suggesting that they may well be maintaining
> it, which is good news IMO.  :-)

I wish that was the case - maybe in the future, I am slowly learning
Guile at the moment :-)

Currently, I can at most support the package definition and change the
url if someone notifies me they want to start actively maintaining it.

So I don't know if you think the patch should be rejected or not.. maybe
the comment about the project being retired should remain, if so I can
resubmit a patch.

Thanks for your comments,
// David L

Re: guile-bash updated source url

[Mark H Weaver]

Hi David,

david.larsson@selfhosted.xyz writes:

> On Fri, 3 May 2019, Ludovic Courtès wrote:
>
>> david.larsson@selfhosted.xyz skribis:
>>
>>> This is my first contribution to guix and it's just a minor fix for
>>> the guile-bash package which had an outdated source url. I was able to
>>> retrieve the same revision of the package via the software-heritage
>>> project's website and upload it to gitlab. Then I installed it
>>> successfully via guix package -f my-guile-bash.scm using the gitlab
>>> url, then copied it to the existing guile-xyz.scm in gnu/packages.
>>
>> [...]
>>
>>> --- a/gnu/packages/guile-xyz.scm
>>> +++ b/gnu/packages/guile-xyz.scm
>>> @@ -294,23 +294,21 @@ dictionary and suggesting spelling corrections.")
>>>      (license license:gpl3+)))
>>>
>>>  (define-public guile-bash
>>> -  ;; This project is currently retired.  It was initially announced here:
>>> -  ;; <https://lists.gnu.org/archive/html/guile-user/2015-02/msg00003.html>.
>>> -  (let ((commit "1eabc563ca5692b3e08d84f1f0e6fd2283284469")
>>> +    (let ((commit "49099fe6a592aa3b8001e826b939869fe5811785")
>>>          (revision "0"))
>>
>> Why is the commit different?  Looks like it’s more than just a mirror.
>>
>> If you made changes on top of the original code, that’s actually great.
>> However, I’d prefer to first see a patch that simply changes the URL,
>> not the commit and hash, and later updates to a different revision.
>>
>> Does that make sense?
>>
>
> I made a commit since I was unable figure out how to create a
> git-mirror from the Software Heritage website but was able to retrieve
> the correct commit as a tarball. Then I guix init'ed the folder, and
> made a commit in order to push it to gitlab.

Hmm.  If I understand correctly, it sounds like this will discard the
entire previous git history.  If you want to maintain this package and
host the repository yourself (as opposed to us relying on Software
Heritage), I would advocate trying again until you can properly clone
the existing repository.  We can help if needed.  It's important to get
this right now, because git history cannot be rewritten after the fact,
and it's important to preserve the existing history.

      Thanks,
        Mark

Re: guile-bash updated source url

[Mark H Weaver]

FYI, David might not have seen my reply below, because my mail server is
unable to perform DNS lookups for his domain, and thus is unable to look
up the MX record to deliver mail to him.  I'm not yet sure what's going
wrong, maybe something in my firewall configuration.

      Mark


Mark H Weaver <mhw@netris.org> writes:

> Hi David,
>
> david.larsson@selfhosted.xyz writes:
>
>> On Fri, 3 May 2019, Ludovic Courtès wrote:
>>
>>> david.larsson@selfhosted.xyz skribis:
>>>
>>>> This is my first contribution to guix and it's just a minor fix for
>>>> the guile-bash package which had an outdated source url. I was able to
>>>> retrieve the same revision of the package via the software-heritage
>>>> project's website and upload it to gitlab. Then I installed it
>>>> successfully via guix package -f my-guile-bash.scm using the gitlab
>>>> url, then copied it to the existing guile-xyz.scm in gnu/packages.
>>>
>>> [...]
>>>
>>>> --- a/gnu/packages/guile-xyz.scm
>>>> +++ b/gnu/packages/guile-xyz.scm
>>>> @@ -294,23 +294,21 @@ dictionary and suggesting spelling corrections.")
>>>>      (license license:gpl3+)))
>>>>
>>>>  (define-public guile-bash
>>>> -  ;; This project is currently retired.  It was initially announced here:
>>>> -  ;; <https://lists.gnu.org/archive/html/guile-user/2015-02/msg00003.html>.
>>>> -  (let ((commit "1eabc563ca5692b3e08d84f1f0e6fd2283284469")
>>>> +    (let ((commit "49099fe6a592aa3b8001e826b939869fe5811785")
>>>>          (revision "0"))
>>>
>>> Why is the commit different?  Looks like it’s more than just a mirror.
>>>
>>> If you made changes on top of the original code, that’s actually great.
>>> However, I’d prefer to first see a patch that simply changes the URL,
>>> not the commit and hash, and later updates to a different revision.
>>>
>>> Does that make sense?
>>>
>>
>> I made a commit since I was unable figure out how to create a
>> git-mirror from the Software Heritage website but was able to retrieve
>> the correct commit as a tarball. Then I guix init'ed the folder, and
>> made a commit in order to push it to gitlab.
>
> Hmm.  If I understand correctly, it sounds like this will discard the
> entire previous git history.  If you want to maintain this package and
> host the repository yourself (as opposed to us relying on Software
> Heritage), I would advocate trying again until you can properly clone
> the existing repository.  We can help if needed.  It's important to get
> this right now, because git history cannot be rewritten after the fact,
> and it's important to preserve the existing history.
>
>       Thanks,
>         Mark

Re: guile-bash updated source url

[david.larsson]

On Wed, 8 May 2019, Mark H Weaver wrote:

> FYI, David might not have seen my reply below, because my mail server is
> unable to perform DNS lookups for his domain, and thus is unable to look
> up the MX record to deliver mail to him.  I'm not yet sure what's going
> wrong, maybe something in my firewall configuration.
>
>      Mark

Hi,

Im not sure why, I do make some scheduled blocklist-updates and resets
around midnight which could have led to a temporary block. (Though I
think most MTA's just resends a few times before giving up so I
haven't concerned myself with this so far).

>
>>> I made a commit since I was unable figure out how to create a
>>> git-mirror from the Software Heritage website but was able to retrieve
>>> the correct commit as a tarball. Then I guix init'ed the folder, and
>>> made a commit in order to push it to gitlab.
>>
>> Hmm.  If I understand correctly, it sounds like this will discard the
>> entire previous git history.  If you want to maintain this package and
>> host the repository yourself (as opposed to us relying on Software
>> Heritage), I would advocate trying again until you can properly clone
>> the existing repository.  We can help if needed.  It's important to get
>> this right now, because git history cannot be rewritten after the fact,
>> and it's important to preserve the existing history.

Yeah unfortunately the gitlab url I added don't have any git
history. If you can help me retrieve it from software heritage like a
git clone or so with the git version history that would be very
nice. I tried finding a way and looked at swh.scm but I couldn't
figure it out within any reasonable amount of time.

Sincerely,
David L