From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tanguy Le Carrour Subject: Re: Problem with `direnv` package definition Date: Sun, 21 Apr 2019 10:34:26 +0200 Message-ID: <20190421083426.6snly2v4xmlneb32@melmoth> References: <20190420132019.priud6wucj5l2rn6@melmoth> <87o950txsa.fsf@cbaines.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([209.51.188.92]:44546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hI7vn-0005uz-D3 for guix-devel@gnu.org; Sun, 21 Apr 2019 04:34:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hI7vm-0004CT-9i for guix-devel@gnu.org; Sun, 21 Apr 2019 04:34:35 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:50233) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hI7vm-0004BO-3W for guix-devel@gnu.org; Sun, 21 Apr 2019 04:34:34 -0400 Content-Disposition: inline In-Reply-To: <87o950txsa.fsf@cbaines.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Christopher Baines Cc: guix-devel@gnu.org Le 04/20, Christopher Baines a écrit : > Tanguy Le Carrour writes: > > However, in the package definition [2], 3 Go packages are listed as > > "inputs" whereas they should be listed as "native-inputs". Is this > > correct? > That sounds right to me, although there have been issues with binaries > generated with Go […] > There's also an important aspect of cross-compilation to these fields, > which you can read about here: > > https://www.gnu.org/software/guix/manual/en/html_node/package-Reference.html Thanks for the link. I do realize that, so close to the release of Guix System 1.0, this can sound trivial, but I find it a little annoying to have `guix size direnv` reporting 594 MiB when the actual binary size is 2.9M. :-( > > As I said, I'm still learning. But I've tried, and here is what I've > > done so far […] > > I tried changing the inputs to native-inputs, and the package built for > me. Could you share the exact changes you made? I haven't done much: --- a/gnu/packages/shellutils.scm +++ b/gnu/packages/shellutils.scm @@ -129,12 +129,11 @@ are already there.") ;; Help the build scripts find the Go language dependencies. (add-before 'unpack 'setup-go-environment (assoc-ref go:%standard-phases 'setup-go-environment))))) - (inputs - `(("go" ,go) - ("go-github-com-burntsushi-toml" ,go-github-com-burntsushi-toml) - ("go-github-com-direnv-go-dotenv" ,go-github-com-direnv-go-dotenv))) (native-inputs - `(("which" ,which))) + `(("go" ,go) + ("go-github-com-burntsushi-toml" ,go-github-com-burntsushi-toml) + ("go-github-com-direnv-go-dotenv" ,go-github-com-direnv-go-dotenv) + ("which" ,which))) (home-page "https://direnv.net/") (synopsis "Environment switcher for the shell") (description Thanks again for your time! -- Tanguy