unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org
Subject: Re: 03/03: gnu: clang-from-llvm: Clean up share/clang folder.
Date: Wed, 28 Nov 2018 12:54:21 +0200	[thread overview]
Message-ID: <20181128105421.GB28059@macbook41> (raw)
In-Reply-To: <87sgzllcuc.fsf@ambrevar.xyz>

[-- Attachment #1: Type: text/plain, Size: 2281 bytes --]

On Wed, Nov 28, 2018 at 11:23:55AM +0100, Pierre Neidhardt wrote:
> I've successfully built clang-3.9.1 with two (file-exists? ...).
> Efraim, let me know if I should push.
> 

If yours works then go ahead and push it. I forgot to check
bash-autocomplete.sh and so my build of clang@3.8 failed. Make sure
yours covers that too.

diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
index 0b12f736a..6197c2795 100644
--- a/gnu/packages/llvm.scm
+++ b/gnu/packages/llvm.scm
@@ -243,13 +243,16 @@ compiler.  In LLVM this library is called \"compiler-rt\".")
                                          out "/etc/bash_completion.d")))
                         (with-directory-excursion (string-append out
                                                                  "/share/clang")
-                          ;; Delete extensions for proprietary text editors.
-                          (delete-file "clang-format-bbedit.applescript")
-                          (delete-file "clang-format-sublime.py")
-                          ;; Delete Emacs extensions: see their respective Emacs
-                          ;; Guix package instead.
-                          (delete-file "clang-rename.el")
-                          (delete-file "clang-format.el")
+                          (for-each
+                            (lambda (file)
+                              (when (file-exists? file)
+                                (delete-file file)))
+                            ;; Delete extensions for proprietary text editors.
+                            '("clang-format-bbedit.applescript"
+                              "clang-format-sublime.py"
+                              ;; Delete Emacs extensions: see their respective Emacs
+                              ;; Guix package instead.
+                              "clang-rename.el" "clang-format.el"))
                           ;; Install bash completion.
                           (mkdir-p compl-dir)
                           (rename-file "bash-autocomplete.sh"


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-11-28 10:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181126135350.20543.84585@vcs0.savannah.gnu.org>
     [not found] ` <20181126135351.C5B4420427@vcs0.savannah.gnu.org>
2018-11-27 23:35   ` 03/03: gnu: clang-from-llvm: Clean up share/clang folder Mark H Weaver
2018-11-28  9:32     ` Efraim Flashner
2018-11-28  9:52       ` Pierre Neidhardt
2018-11-28 10:23         ` Pierre Neidhardt
2018-11-28 10:54           ` Efraim Flashner [this message]
2018-11-28 12:43             ` Pierre Neidhardt
2018-11-28 13:23       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128105421.GB28059@macbook41 \
    --to=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).