From: Leo Famulari <leo@famulari.name>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: Packaging gx (for IPFS): Need to update default Go to 1.11?
Date: Wed, 7 Nov 2018 16:03:09 -0500 [thread overview]
Message-ID: <20181107210309.GA30589@jasmine.lan> (raw)
In-Reply-To: <87d0rgmx59.fsf@ambrevar.xyz>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Wed, Nov 07, 2018 at 09:48:50PM +0100, Pierre Neidhardt wrote:
> In my patchset, there are 2 kinds of fixes:
>
> - Disabling tests because Go 1.11 test policies are stricter and some lax code
> from before does not pass anymore.
> For this issue, upstream should fix their packages. As far as we are
> concerned, disabling tests is enough. The go-build-system has nothing to do
> with this issue.
Okay, I think you should go ahead and push these changes now, assuming
the packages still build afterwards.
> - Manual forwarding of compilation flags (e.g. "-tags"). This is an issue with
> our go-build-system which cannot re-use existing "pkg" objects on Go 1.11.
> Upstream code is fine.
>
> So yes, fixing go-build-system is related to packages not building with
> Go 1.11 :p
Okay, I see. I won't be working on this soon, if ever. I don't
understand enough about how Go >= 1.10 builds software in order to do
the work efficiently. Hopefully there is a volunteer :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-07 21:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 11:40 Packaging gx (for IPFS): Need to update default Go to 1.11? Pierre Neidhardt
2018-10-24 11:42 ` Pierre Neidhardt
2018-10-24 13:55 ` Leo Famulari
2018-10-24 14:02 ` Pierre Neidhardt
2018-10-24 14:14 ` Leo Famulari
2018-11-06 11:56 ` Pierre Neidhardt
2018-11-06 12:03 ` Pierre Neidhardt
2018-11-06 17:04 ` Pierre Neidhardt
2018-11-06 17:31 ` Leo Famulari
2018-11-06 17:33 ` Pierre Neidhardt
2018-11-06 19:57 ` Leo Famulari
2018-11-07 7:33 ` Pierre Neidhardt
2018-11-07 16:22 ` Pierre Neidhardt
2018-11-07 18:26 ` Leo Famulari
2018-11-07 20:09 ` Pierre Neidhardt
2018-11-07 20:40 ` Leo Famulari
2018-11-07 20:48 ` Pierre Neidhardt
2018-11-07 21:03 ` Leo Famulari [this message]
2018-11-11 16:43 ` Pierre Neidhardt
2018-11-11 20:52 ` Pierre Neidhardt
2018-11-11 21:33 ` Pierre Neidhardt
2018-11-12 9:45 ` Pierre Neidhardt
2018-11-12 17:33 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107210309.GA30589@jasmine.lan \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).