unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: "Gábor Boskovits" <boskovits@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: Making javadoc reproducible
Date: Mon, 15 Oct 2018 12:09:46 +0200	[thread overview]
Message-ID: <20181015120946.458cd536@scratchpost.org> (raw)
In-Reply-To: <CAE4v=phFRSq98fJGz4b0mVvSUTfnuOVO+tUwqNGGKxHfMDTtVg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

Hi Gabor,

> There is a command line flag for javadoc (notimestamp), that disables
> generating the comment in the docs that contains the timestamp.
> Currently I see two ways forward:
> 1. Track down the calls to javadoc, and add the flag to all calls.
> 2. Write a simple patch to make javadoc behave as if notimestamp was
> specified, whenever
> SOURCE_DATE_EPOCH is defined.
> I do not think, that the patch produced by 2 is upstreamable, but it
> seems much less work. WDYT?

I'd like option 2 more.  Also, I think it should be upstreamable.

Thanks for working on tihs!

I've meant to tackle this for quite some time but I didn't find how icedtea
gets the jdk sources in the first place (in order to patch it).

Putting a patch into the "patches" subdir blindly should work, but I
didn't try.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2018-10-15 10:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12 17:00 Making javadoc reproducible Gábor Boskovits
2018-10-12 17:35 ` Gábor Boskovits
2018-10-12 18:01   ` Björn Höfling
2018-10-12 18:14     ` Gábor Boskovits
2019-05-19  9:57       ` Mykola Nikishov
2019-05-19 13:46         ` Gábor Boskovits
2018-10-12 18:42     ` Vagrant Cascadian
2018-10-13 21:06       ` Alex Vong
2018-10-14  3:35       ` Chris Marusich
2018-10-14  6:43         ` Gábor Boskovits
2018-10-14 19:19           ` Gábor Boskovits
2018-10-15 10:09 ` Danny Milosavljevic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181015120946.458cd536@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=boskovits@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).