Re: [PATCH 0/1] Go importer

[Leo Famulari <leo@famulari.name>]

[-- Attachment #1: Type: text/plain, Size: 4588 bytes --]

On Thu, Jul 19, 2018 at 08:56:03AM +0200, Pierre-Antoine Rouby wrote:
> I trying to import 'gitlab-runner' (https://gitlab.com/gitlab-org/gitlab-runner)
> with tag 'v10.6.0'.

Okay, thanks. I can reproduce the error:

------
$ ./pre-inst-env guix import gopkg https://gitlab.com/gitlab-org/gitlab-runner v10.6.0  
Initialized empty Git repository in /tmp/guix-directory.silSgB/.git/                                       
warning: redirecting to https://gitlab.com/gitlab-org/gitlab-runner.git/
remote: Counting objects: 10694, done.
remote: Compressing objects: 100% (8261/8261), done.
remote: Total 10694 (delta 1974), reused 8461 (delta 1826)
Receiving objects: 100% (10694/10694), 29.12 MiB | 2.57 MiB/s, done.
Resolving deltas: 100% (1974/1974), done.
From https://gitlab.com/gitlab-org/gitlab-runner
 * tag               v10.6.0    -> FETCH_HEAD
Note: checking out 'FETCH_HEAD'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at a3543a2 Update v10.6.0 changelog
Backtrace:
          14 (apply-smob/1 #<catch-closure 1af03e0>)
In ice-9/boot-9.scm:
    705:2 13 (call-with-prompt _ _ #<procedure default-prompt-handle…>)
In ice-9/eval.scm:
    619:8 12 (_ #(#(#<directory (guile-user) 1b88140>)))
In guix/ui.scm:
  1579:12 11 (run-guix-command _ . _)
In guix/scripts/import.scm:
   115:11 10 (guix-import . _)
In guix/scripts/import/gopkg.scm:
    85:19  9 (guix-import-gopkg . _)
In guix/utils.scm:
    633:8  8 (call-with-temporary-directory #<procedure 1fc0900 at g…>)
In guix/import/gopkg.scm:
   343:22  7 (_ "/tmp/guix-directory.silSgB")
   322:22  6 (gopkg-dep->packages+dependencies _)
   303:22  5 (parse-toml->packages+dependencies _ _ _)
   216:16  4 (create-package->packages+dependencies () () "github.c…" …)
     47:4  3 (file->hash-base32 #<input: /tmp/guix-directory.silSgB/…>)
In guix/serialization.scm:
    343:6  2 (dump #<input: /tmp/guix-directory.silSgB/Gopkg.toml 13>)
   275:34  1 (_ _)
In unknown file:
           0 (lstat #<input: /tmp/guix-directory.silSgB/Gopkg.toml 13>)

ERROR: In procedure lstat:
Wrong type (expecting string): #<input: /tmp/guix-directory.silSgB/Gopkg.toml 13>
------

It does work with some other packages. I guess the difference is whether
or not the package has a 'Gopkg.toml' file. For example, this works:

------
$ ./pre-inst-env guix import gopkg https://gopkg.in/redsync.v1                        
Initialized empty Git repository in /tmp/guix-directory.6rwYux/.git/                    
remote: Counting objects: 13, done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 13 (delta 0), reused 10 (delta 0), pack-reused 0
Unpacking objects: 100% (13/13), done.
From https://gopkg.in/redsync.v1
 * branch            master     -> FETCH_HEAD
 * [new branch]      master     -> origin/master
Note: checking out 'FETCH_HEAD'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 98dabdf Merge pull request #2 from rayzyar/master
(define-public go-gopkg-in-redsync-v1
  (let ((commit
          "98dabdf1c8574561bf976911c14ff652c47b1ddf")
        (revision "0"))
    (package
      (name "go-gopkg-in-redsync-v1")
      (version (git-version "0.0.0" revision commit))
      (source
        (origin
          (method git-fetch)
          (uri (git-reference
                 (url "https://gopkg.in/redsync.v1.git")
                 (commit commit)))
          (file-name (git-file-name name version))
          (sha256
            (base32
              "1ir3xj8rz2igw5ciha2nhkvs55w0yf2k1w5xyizy8d0r4xh3x1p5"))))
      (build-system go-build-system)
      (arguments
        '(#:import-path "gopkg.in/redsync.v1"))
      (native-inputs `())
      (home-page "https://gopkg.in/redsync.v1")
      (synopsis "XXX")
      (description "XXX")
      (license #f))))
------

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]