unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Bavier <bavier@cray.com>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: guix-devel@gnu.org
Subject: Re: fftw runtime cpu detection
Date: Fri, 6 Apr 2018 10:02:32 -0500	[thread overview]
Message-ID: <20180406150232.GU105827@pe06.us.cray.com> (raw)
In-Reply-To: <87sh883gko.fsf@gnu.org>

On Fri, Apr 06, 2018 at 10:05:43AM +0200, Ludovic Courtès wrote:
> Hello Eric,
> 
> Eric Bavier <bavier@cray.com> skribis:
> 
> > I recently discovered that the FFTW library can do runtime cpu
> > detection.  In order to do this, the package needs to be configured to
> > build SIMD "codelets", like how our 'fftw-avx' currently does.  Then,
> > based on the instruction support detected at runtime, make those
> > kernels available to the fftw "planner" for execution.
> 
> That’s really good news!  Thanks for testing it.
> 
> The patch LGTM.  Can you confirm that the planner won’t ever try to use
> the AVX2 codelets, for instance when running the test suite on an x86_64
> box that lacks AVX2?

Yes, I've successfully run 'make check' on an sse2-only machine where
'--enable-avx' and '--enable-avx2' where configured.  I'll check on an
i686 machine tonight.

> If that’s the case, I’d be in favor of pushing this patch to core-updates.

Great.  I'll do some more testing.  Should I send a finalized patch to
guix-patches when it's ready?

-- 
Eric Bavier, Scientific Libraries, Cray Inc.

  reply	other threads:[~2018-04-06 15:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 22:13 fftw runtime cpu detection Eric Bavier
2018-04-06  7:54 ` Chris Marusich
2018-04-06 15:08   ` Eric Bavier
2018-04-06  8:05 ` Ludovic Courtès
2018-04-06 15:02   ` Eric Bavier [this message]
2018-04-06 15:09     ` Ludovic Courtès
2018-04-06 18:37       ` Marius Bakke
2018-04-17 21:29         ` Eric Bavier
2018-04-18 21:36           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180406150232.GU105827@pe06.us.cray.com \
    --to=bavier@cray.com \
    --cc=guix-devel@gnu.org \
    --cc=ludovic.courtes@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).