Recent libx264 updates broke mpv via ffmpeg-git

Recent libx264 updates broke mpv via ffmpeg-git

[Mark H Weaver]

Hi Efraim and Danny,

efraim@flashner.co.il (Efraim Flashner) writes:

> efraim pushed a commit to branch master
> in repository guix.
>
> commit a33727db1bf0eaf4a0024da45610bd8e3e727a8e
> Author: Efraim Flashner <efraim@flashner.co.il>
> Date:   Tue Feb 20 23:34:07 2018 +0200
>
>     gnu: libx264: Update to 20180219-2245.

dannym@scratchpost.org (Danny Milosavljevic) writes:

> dannym pushed a commit to branch master
> in repository guix.
>
> commit a0343008dc7edae60446177f2e10ca57c10112dc
> Author: Danny Milosavljevic <dannym@scratchpost.org>
> Date:   Wed Feb 21 20:25:00 2018 +0100
>
>     gnu: libx264: Use nasm.

One of these two commits seem to have broken the 'ffmpeg-git' build,
needed by 'mpv', on my x86_64 GuixSD system.  Here's an excerpt of the
failed log:

--8<---------------cut here---------------start------------->8---
CC      libavcodec/libvpx.o
CC      libavcodec/libvpxdec.o
CC      libavcodec/libvpxenc.o
CC      libavcodec/libx264.o
libavcodec/libx264.c: In function ‘X264_frame’:
libavcodec/libx264.c:282:9: error: ‘x264_bit_depth’ undeclared (first use in this function)
     if (x264_bit_depth > 8)
         ^
libavcodec/libx264.c:282:9: note: each undeclared identifier is reported only once for each function it appears in
libavcodec/libx264.c: In function ‘X264_init_static’:
libavcodec/libx264.c:876:9: error: ‘x264_bit_depth’ undeclared (first use in this function)
     if (x264_bit_depth == 8)
         ^
make: *** [ffbuild/common.mak:60: libavcodec/libx264.o] Error 1
make: *** Waiting for unfinished jobs....
phase `build' failed after 340.6 seconds
note: keeping build directory `/tmp/guix-build-ffmpeg-git-3.4-1.3f8874406.drv-0'
builder for `/gnu/store/wka754abrdiwi481qgiprhwh67q2n3ih-ffmpeg-git-3.4-1.3f8874406.drv' failed with exit code 1
cannot build derivation `/gnu/store/9ddbwwzzdl30fx26sv4jsnmg3ddklqap-mpv-0.28.2.drv': 1 dependencies couldn't be built
guix package: error: build failed: build of `/gnu/store/9ddbwwzzdl30fx26sv4jsnmg3ddklqap-mpv-0.28.2.drv' failed
--8<---------------cut here---------------end--------------->8---

Could you take a look?

       Mark

Re: Recent libx264 updates broke mpv via ffmpeg-git

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]

On Thu, Feb 22, 2018 at 03:52:13PM -0500, Mark H Weaver wrote:
> One of these two commits seem to have broken the 'ffmpeg-git' build,
> needed by 'mpv', on my x86_64 GuixSD system.  Here's an excerpt of the
> failed log:
> 
> --8<---------------cut here---------------start------------->8---
> CC      libavcodec/libvpx.o
> CC      libavcodec/libvpxdec.o
> CC      libavcodec/libvpxenc.o
> CC      libavcodec/libx264.o
> libavcodec/libx264.c: In function ‘X264_frame’:
> libavcodec/libx264.c:282:9: error: ‘x264_bit_depth’ undeclared (first use in this function)
>      if (x264_bit_depth > 8)
>          ^
> libavcodec/libx264.c:282:9: note: each undeclared identifier is reported only once for each function it appears in
> libavcodec/libx264.c: In function ‘X264_init_static’:
> libavcodec/libx264.c:876:9: error: ‘x264_bit_depth’ undeclared (first use in this function)
>      if (x264_bit_depth == 8)
>          ^
> make: *** [ffbuild/common.mak:60: libavcodec/libx264.o] Error 1
> make: *** Waiting for unfinished jobs....
> phase `build' failed after 340.6 seconds
> note: keeping build directory `/tmp/guix-build-ffmpeg-git-3.4-1.3f8874406.drv-0'
> builder for `/gnu/store/wka754abrdiwi481qgiprhwh67q2n3ih-ffmpeg-git-3.4-1.3f8874406.drv' failed with exit code 1
> cannot build derivation `/gnu/store/9ddbwwzzdl30fx26sv4jsnmg3ddklqap-mpv-0.28.2.drv': 1 dependencies couldn't be built
> guix package: error: build failed: build of `/gnu/store/9ddbwwzzdl30fx26sv4jsnmg3ddklqap-mpv-0.28.2.drv' failed
> --8<---------------cut here---------------end--------------->8---

I can't reproduce this since commit bb2a95580e1db (gnu: libx264: Change
to stable branch).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Recent libx264 updates broke mpv via ffmpeg-git

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2179 bytes --]

On Thu, Feb 22, 2018 at 04:13:50PM -0500, Leo Famulari wrote:
> On Thu, Feb 22, 2018 at 03:52:13PM -0500, Mark H Weaver wrote:
> > One of these two commits seem to have broken the 'ffmpeg-git' build,
> > needed by 'mpv', on my x86_64 GuixSD system.  Here's an excerpt of the
> > failed log:
> > 
> > --8<---------------cut here---------------start------------->8---
> > CC      libavcodec/libvpx.o
> > CC      libavcodec/libvpxdec.o
> > CC      libavcodec/libvpxenc.o
> > CC      libavcodec/libx264.o
> > libavcodec/libx264.c: In function ‘X264_frame’:
> > libavcodec/libx264.c:282:9: error: ‘x264_bit_depth’ undeclared (first use in this function)
> >      if (x264_bit_depth > 8)
> >          ^
> > libavcodec/libx264.c:282:9: note: each undeclared identifier is reported only once for each function it appears in
> > libavcodec/libx264.c: In function ‘X264_init_static’:
> > libavcodec/libx264.c:876:9: error: ‘x264_bit_depth’ undeclared (first use in this function)
> >      if (x264_bit_depth == 8)
> >          ^
> > make: *** [ffbuild/common.mak:60: libavcodec/libx264.o] Error 1
> > make: *** Waiting for unfinished jobs....
> > phase `build' failed after 340.6 seconds
> > note: keeping build directory `/tmp/guix-build-ffmpeg-git-3.4-1.3f8874406.drv-0'
> > builder for `/gnu/store/wka754abrdiwi481qgiprhwh67q2n3ih-ffmpeg-git-3.4-1.3f8874406.drv' failed with exit code 1
> > cannot build derivation `/gnu/store/9ddbwwzzdl30fx26sv4jsnmg3ddklqap-mpv-0.28.2.drv': 1 dependencies couldn't be built
> > guix package: error: build failed: build of `/gnu/store/9ddbwwzzdl30fx26sv4jsnmg3ddklqap-mpv-0.28.2.drv' failed
> > --8<---------------cut here---------------end--------------->8---
> 
> I can't reproduce this since commit bb2a95580e1db (gnu: libx264: Change
> to stable branch).

I tested with the stable branch reverted and my commit reverted, with
just the yasm->nasm change and I ffmpeg-git built fine.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]