From: Pjotr Prins <pjotr.public12@thebird.nl>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: /gnu/store/.links/
Date: Fri, 9 Feb 2018 18:56:27 +0100 [thread overview]
Message-ID: <20180209175627.GA7570@thebird.nl> (raw)
In-Reply-To: <87372ayu7h.fsf@gnu.org>
On Fri, Feb 09, 2018 at 06:00:02PM +0100, Ludovic Courtès wrote:
> In practice, when the maximum number of links is reached, we simply
> transparently skip deduplication. See this commit:
>
> commit 12b6c951cf5ca6055a22a2eec85665353f5510e5
> Author: Ludovic Courtès <ludo@gnu.org>
> Date: Fri Oct 28 20:34:15 2016 +0200
>
> daemon: Do not error out when deduplication fails due to ENOSPC.
>
> This solves a problem whereby if /gnu/store/.links had enough entries,
> ext4's directory index would be full, leading to link(2) returning
> ENOSPC.
>
> * nix/libstore/optimise-store.cc (LocalStore::optimisePath_): Upon
> ENOSPC from link(2), print a message and return instead of throwing a
> 'SysError'.
>
> It does scale well, and it’s been here “forever”.
OK. My mindset is probably ext2...
> If you’re wondering how much gets deduplicated, see
> <https://lists.gnu.org/archive/html/guix-devel/2014-09/msg00422.html>.
> :-)
Fancy that :)
Pj.
next prev parent reply other threads:[~2018-02-09 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 11:22 /gnu/store/.links/ Pjotr Prins
2018-02-09 12:11 ` /gnu/store/.links/ Ricardo Wurmus
2018-02-09 14:24 ` /gnu/store/.links/ Pjotr Prins
2018-02-09 17:00 ` /gnu/store/.links/ Ludovic Courtès
2018-02-09 17:56 ` Pjotr Prins [this message]
2018-02-09 18:08 ` /gnu/store/.links/ Mark H Weaver
2018-02-09 18:23 ` /gnu/store/.links/ Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209175627.GA7570@thebird.nl \
--to=pjotr.public12@thebird.nl \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).