From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: core-updates, =?UTF-8?Q?let=E2=80=99s?= go! Date: Sun, 31 Dec 2017 13:20:37 +0100 Message-ID: <20171231132037.0dc3f964@scratchpost.org> References: <87shbr19ba.fsf@gnu.org> <20171231103219.GB5133@macbook41> <20171231121416.5df20c3b@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eVcbm-0001u8-QM for guix-devel@gnu.org; Sun, 31 Dec 2017 07:20:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eVcbi-0000yV-J6 for guix-devel@gnu.org; Sun, 31 Dec 2017 07:20:54 -0500 In-Reply-To: <20171231121416.5df20c3b@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: Guix-devel On Sun, 31 Dec 2017 12:14:16 +0100 Danny Milosavljevic wrote: > I'd like to get the patch > > [bug#29856] [PATCH core-updates] guix: python-build-system: Modify ".py" files in-place. > > into this core-updates cycle. What do you all think? > > If we don't do it then a lot of Python programs (the ones who use "console_scripts" in setup.py as they should) will not work (because we emit a shell script wrapper and Python tries to import it - that's going to end badly). On the other hand, I don't know the effect on other programs (read: I didn't build the world with it - but I did build quite a few Python programs). You can try it with the guix package ledger-agent and try to invoke "ledger-agent". > > The patch only affects files whose names end in ".py" since Python's importer will only find those in any case. So its possible ill effect is limited. ^^^ Correction: whose names end in ".py" and that end up in "bin" or "sbin". Otherwise it would be common. > > Hartmut, what do you think? -- W: https://www.friendly-machines.at/