From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rutger Helling Subject: Re: 01/01: gnu: qemu: Enable Samba support. Date: Wed, 27 Dec 2017 23:56:15 +0100 Message-ID: <20171227235615.089cd239@mykolab.com> References: <20171227092649.22335.79799@vcs0.savannah.gnu.org> <20171227092650.69D7B204F7@vcs0.savannah.gnu.org> <87r2rfn5pc.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/frH6u09laXP6P9Gxss4p8Hf"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUKcg-0003mk-Ue for guix-devel@gnu.org; Wed, 27 Dec 2017 17:56:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUKcd-0004yb-Os for guix-devel@gnu.org; Wed, 27 Dec 2017 17:56:30 -0500 Received: from mx.kolabnow.com ([95.128.36.42]:5414) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eUKcd-0004wN-CH for guix-devel@gnu.org; Wed, 27 Dec 2017 17:56:27 -0500 In-Reply-To: <87r2rfn5pc.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --Sig_/frH6u09laXP6P9Gxss4p8Hf Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Thanks for the tip! I'll keep it in mind for the future. On Wed, 27 Dec 2017 17:53:19 -0500 Mark H Weaver wrote: > Hi, >=20 > rhelling@mykolab.com (Rutger Helling) writes: >=20 > > rhelling pushed a commit to branch master > > in repository guix. > > > > commit 84276503059d46c0a42240f8770f59090614d863 > > Author: Rutger Helling > > Date: Wed Dec 27 10:09:26 2017 +0100 > > > > gnu: qemu: Enable Samba support. > > =20 > > * gnu/packages/virtualization.scm (qemu)[arguments]: Change > > #:configure-flags to a list, add --smbd flag. > > [inputs]: Add samba. =20 >=20 > I see that you have since reverted this commit, but I still thought > I'd mention that when adding optional features to 'qemu', it would be > good to remove them from 'qemu-minimal', which inherits from 'qemu'. >=20 > Thanks, > Mark --Sig_/frH6u09laXP6P9Gxss4p8Hf Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEAVThuRzJ2e93ZI3n86cn20T8yjYFAlpEJQ8ACgkQ86cn20T8 yjaUHgf9Hxsau9NnhPe5krBjhS2+UgH/YSBQ5Ut6rOFxpC/u7kgmqAwD75/LzuoC ViVTRUGqEdm3yqV9Kvgdei+/s5A242ilBQ21OGs/9z4t+Lg454a61YdVKUXD8dfR oHxpTVdMMriuXVC7gKNCxqMYqN9oeXW3FwrZJat3b2+FUlMNNuyKi6/4V89bEz8J uvu/dTsCMU5WIPeZedoI4m+ctS+mlviesgIBV+0T9YzvOiqec8ABQXCml9riEQLb O+UnUsPTHP92ctrcm1V1IEX8QD8A1RLNZ4CLsVlH9Q3IeBXAzDXFLlpwzPKTqoU8 2EzB9zdV1EZg7ni2RWOGlndO8iv20A== =MYWS -----END PGP SIGNATURE----- --Sig_/frH6u09laXP6P9Gxss4p8Hf--