From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rutger Helling Subject: Re: 01/01: gnu: qemu: Enable Samba support. Date: Wed, 27 Dec 2017 21:59:25 +0100 Message-ID: <20171227215925.28dbde34@mykolab.com> References: <20171227092649.22335.79799@vcs0.savannah.gnu.org> <20171227092650.69D7B204F7@vcs0.savannah.gnu.org> <87po704bt2.fsf@gnu.org> <20171227142331.75ead448@mykolab.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/SYyR0v3IwhAocrvAcp_hjtZ"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUInk-0005nN-00 for guix-devel@gnu.org; Wed, 27 Dec 2017 15:59:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUIng-0001DC-Nd for guix-devel@gnu.org; Wed, 27 Dec 2017 15:59:47 -0500 In-Reply-To: <20171227142331.75ead448@mykolab.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Cc: guix-devel@gnu.org --Sig_/SYyR0v3IwhAocrvAcp_hjtZ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I've created a wrapper for Samba that seems to do the trick, with a big caveat. It doesn't error out when Samba is not actually available. I'd prefer adding Samba directely, but if that's not an option it's better than nothing. I'll send it in later this week after cleaning it up a bit. On Wed, 27 Dec 2017 14:23:31 +0100 Rutger Helling wrote: > Sorry, I hadn't thought of that! I've reverted it for now. >=20 > Would another option be to inherit to a new package? Something like > qemu-full, where we could more easily turn on all the bells and > whistles that Qemu has? >=20 > On Wed, 27 Dec 2017 13:04:09 +0100 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: >=20 > > Hello, > >=20 > > rhelling@mykolab.com (Rutger Helling) skribis: > > =20 > > > commit 84276503059d46c0a42240f8770f59090614d863 > > > Author: Rutger Helling > > > Date: Wed Dec 27 10:09:26 2017 +0100 > > > > > > gnu: qemu: Enable Samba support. > > > =20 > > > * gnu/packages/virtualization.scm (qemu)[arguments]: Change > > > #:configure-flags to a list, add --smbd flag. > > > [inputs]: Add samba. =20 > >=20 > > [...] > > =20 > > > + #:configure-flags (list "--enable-usb-redir" > > > "--enable-opengl" > > > + (string-append "--smbd=3D" > > > + (assoc-ref > > > %build-inputs "samba") > > > + "/sbin/smbd")) =20 > >=20 > > For the record, we removed the dependency on Samba long ago (commit > > b344c505f4dff2ecbe981f0a0a3c3d67b222dcca), largely because Samba is > > a huge dependency: > >=20 > > --8<---------------cut here---------------start------------->8--- > > $ guix size qemu | tail -1 > > total: 817.4 MiB > > $ guix size qemu samba | tail -1 > > total: 1176.0 MiB > > --8<---------------cut here---------------end--------------->8--- > >=20 > > As it stands I=E2=80=99d still be in favor of not having the default = =E2=80=98qemu=E2=80=99 > > depend on Samba. > >=20 > > Perhaps one solution would be to change the =E2=80=98exec=E2=80=99 call= that invokes > > =E2=80=98smbd=E2=80=99 to =E2=80=98execlp=E2=80=99 (or similar) so that= =E2=80=98smbd=E2=80=99 is search for in > > $PATH. That way, if the user installs Samba, then support is > > available, otherwise it=E2=80=99s missing. > >=20 > > WDYT? > >=20 > > Thanks, > > Ludo=E2=80=99. =20 >=20 --Sig_/SYyR0v3IwhAocrvAcp_hjtZ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEAVThuRzJ2e93ZI3n86cn20T8yjYFAlpECa0ACgkQ86cn20T8 yjaKLwf9Hly5EUN5+HZjKAxcHrBxlDVp0QN93RmAq55pYDwxlJiJeFLnoJP1DIn/ /LR+mOd6Yrn1lww6bAOFtjxVR4H/ndOHNqtLsuFt+i8utmalbwZjE7IoXzRbTmDc +ZiVyeH7MU9G1ZOZtK3p3sxkT67oJu3AahSfBmX0ukL8qiDpXjbElAIK/lo6l23O 0+jqHY7C8VsPZvBo13GQdzLor2Z8hWdxw2sKg6jnFZXCEC6IhS9IRLP1xh/3Yh2Q tbYdBc6HSdosCVEy+6U+hzXG2Arg7e9PPVaHWVw9is9VIstdqVvj75oSK6ygOos7 GzydpAZOwUEkSlDKhmPj09RtbI2mqg== =Gp9G -----END PGP SIGNATURE----- --Sig_/SYyR0v3IwhAocrvAcp_hjtZ--