From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rutger Helling Subject: Re: 01/01: gnu: qemu: Enable Samba support. Date: Wed, 27 Dec 2017 14:23:31 +0100 Message-ID: <20171227142331.75ead448@mykolab.com> References: <20171227092649.22335.79799@vcs0.savannah.gnu.org> <20171227092650.69D7B204F7@vcs0.savannah.gnu.org> <87po704bt2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/hb=zQXK+xdsdhnim_TAyJbi"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUBgl-0000vH-1P for guix-devel@gnu.org; Wed, 27 Dec 2017 08:24:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUBgg-0005kf-Ms for guix-devel@gnu.org; Wed, 27 Dec 2017 08:24:07 -0500 In-Reply-To: <87po704bt2.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Cc: guix-devel@gnu.org --Sig_/hb=zQXK+xdsdhnim_TAyJbi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sorry, I hadn't thought of that! I've reverted it for now. Would another option be to inherit to a new package? Something like qemu-full, where we could more easily turn on all the bells and whistles that Qemu has? On Wed, 27 Dec 2017 13:04:09 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hello, >=20 > rhelling@mykolab.com (Rutger Helling) skribis: >=20 > > commit 84276503059d46c0a42240f8770f59090614d863 > > Author: Rutger Helling > > Date: Wed Dec 27 10:09:26 2017 +0100 > > > > gnu: qemu: Enable Samba support. > > =20 > > * gnu/packages/virtualization.scm (qemu)[arguments]: Change > > #:configure-flags to a list, add --smbd flag. > > [inputs]: Add samba. =20 >=20 > [...] >=20 > > + #:configure-flags (list "--enable-usb-redir" > > "--enable-opengl" > > + (string-append "--smbd=3D" > > + (assoc-ref > > %build-inputs "samba") > > + "/sbin/smbd")) =20 >=20 > For the record, we removed the dependency on Samba long ago (commit > b344c505f4dff2ecbe981f0a0a3c3d67b222dcca), largely because Samba is a > huge dependency: >=20 > --8<---------------cut here---------------start------------->8--- > $ guix size qemu | tail -1 > total: 817.4 MiB > $ guix size qemu samba | tail -1 > total: 1176.0 MiB > --8<---------------cut here---------------end--------------->8--- >=20 > As it stands I=E2=80=99d still be in favor of not having the default =E2= =80=98qemu=E2=80=99 > depend on Samba. >=20 > Perhaps one solution would be to change the =E2=80=98exec=E2=80=99 call t= hat invokes > =E2=80=98smbd=E2=80=99 to =E2=80=98execlp=E2=80=99 (or similar) so that = =E2=80=98smbd=E2=80=99 is search for in $PATH. > That way, if the user installs Samba, then support is available, > otherwise it=E2=80=99s missing. >=20 > WDYT? >=20 > Thanks, > Ludo=E2=80=99. --Sig_/hb=zQXK+xdsdhnim_TAyJbi Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEAVThuRzJ2e93ZI3n86cn20T8yjYFAlpDntQACgkQ86cn20T8 yjZpewf+JBZ2f88qEC0lL9QmfTcslrnt/Tq4zNdUIH6Q/Nq9zHTwdnKN1Q/tlMTM gKBnbZKX6rQ6HTNE7ueTGlvFFx32pf8ACz4PL3eNx5LATxU1sTkFZHUgHSv59P8s iSQHnH1ZkyHbUtoY2ntZRFm53FBP82xyIW7IBBgXHpBgIevAFS7HQIn61w+akMPd Vk1b1kccK5WcOG22kkAiiKZXeQTm378g6z9dRkDAAS1vBXHEdnI53lzxH7IL5Ig3 wSVKTnSEDjHaSvIpHdkJT2GTf0y2PUCudPZn5RqzcOu4/keQjDwCNdejYepZ+swt j39xw31leRdPvtz2yLTdP8sD6JGyzg== =ymlo -----END PGP SIGNATURE----- --Sig_/hb=zQXK+xdsdhnim_TAyJbi--