From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: Packaging LyX Date: Fri, 22 Dec 2017 18:42:31 +0000 Message-ID: <20171222184231.an2qywtr4ilmcqb5@abyayala> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7rautxzl4pxhcleu" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSSHZ-00027j-8n for guix-devel@gnu.org; Fri, 22 Dec 2017 13:42:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eSSHW-00025Z-3B for guix-devel@gnu.org; Fri, 22 Dec 2017 13:42:57 -0500 Received: from aibo.runbox.com ([91.220.196.211]:52508) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eSSHV-000248-RA for guix-devel@gnu.org; Fri, 22 Dec 2017 13:42:54 -0500 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Gammel Holte Cc: guix-devel@gnu.org --7rautxzl4pxhcleu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Gammel Holte transcribed 5.8K bytes: > Hi all, >=20 > I'm planning to switch a dozen or so machines to GuixSD. >=20 > The only major package my users are missing is LyX (a LaTeX editor, see > https://www.lyx.org/) so I packaged it, and it works fine. See code below. >=20 > I would appreciate some help wrapping python. I'm familiar how to do this > in Nix, but not in Guix. Despite requiring a python interpreter for during > build, LyX dynamically looks for a python interpreter at runtime. > Obviously, it'd be desirable to link LyX to the python instance used as > input. For the record this is the LyX package in Nixpkgs: >=20 > https://github.com/NixOS/nixpkgs/blob/86da6d441f7a248b02d545ac1b2c90ef27f= 42d0b/pkgs/applications/misc/lyx/default.nix >=20 > I also had some doubts when packaging: >=20 > - Is a xz source preferred to a gz one? I would say it doesn't matter. For the files produced, xz is smaller in most cases. Pick what you see fit. > - Nix uses qtcore and qtsvg as inputs, but if I use these in Guix (in pla= ce > of the whole qt) then LyX can't render its icons (svgz) This shouldn't be a blocker. If it works with qt, that's okay. We can strip it down to individual Qt modules later on. Nix can be used as an inspiration but they do some things differently. > There are another minor TODOs: >=20 > - Transition to proper package and define-public syntax, as I was > installing with guix package -f > - Decide whether the package should live in tex.scm or elsewhere I think (gnu packages editors) or what the editor module is called again would be better. > Once this is done, I'm happy to submit a proper patch. >=20 > Thanks. >=20 > (use-modules > (guix packages) > (guix download) > (guix build-system gnu) > (guix licenses) > (gnu packages algebra) > (gnu packages compression) > (gnu packages pkg-config) > (gnu packages python) > (gnu packages qt)) >=20 > (package > (name "lyx") > (version "2.2.3") > (source (origin > (method url-fetch) > (uri (string-append "ftp://ftp.lyx.org/pub/lyx/stable/2.2.x/lyx-" > version ".tar.gz")) > (sha256 > (base32 "0xvaz0i371nn2ndinc0d3ywj76ivb62649a4sdgwbivisiahd2fj")))) > (build-system gnu-build-system) > (inputs `(("pkg-config" ,pkg-config) > ("python" ,python-2) Is this python-2 only? If not, could you explain why you picked 2 and not 3 (2 is on its way out in 20 months). > ("qt" ,qt) > ("bc" ,bc) > ("zlib" ,zlib))) > (arguments `(#:configure-flags (list "--enable-qt5"))) > (home-page "http://www.lyx.org") > (synopsis "An advanced WYSIWYM document processor and LaTeX front-end") I'd drop the "An" and simply write (synopsis "Advanced WYSIWYM document processor and LaTeX front-end") > (description "LyX is a document processor that encourages an approach > to writing based on the structure of your documents (WYSIWYM) and not > simply their appearance (WYSIWYG). LyX combines the power and > flexibility of TeX/LaTeX with the ease of use of a graphical > interface.") You need to use two spaces between sentences here. > (license gpl2+)) Otherwise looks good to me with some indendation adjustments. If you send a patch for master to a new bug ticket I can test it and give additional feedback. Thanks --=20 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys WWW: https://n0.is --7rautxzl4pxhcleu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlo9UhcACgkQ4i+bv+40 hYgaRA/+O1EuNjjp/PE0vY7Kyl5wxSR2IUyOyr+MeA1/cbKK0CHxzH6UqDSGkxJr MvTgMCGtr0pAGGGRK+9Y+6l3vF0+eWmY1+tDb6eoqvtcs6vx26XyeyuFHmktiGta 0Pis2I+/L4umaMN8fwLlGWJdZ2GDRHdWSts44Ok5ImNQP0zQ16FDbF2R+uqbFDr+ cx+gzlIhricIxMuUT/ejKG5M19BjEAshuvbDoNH5dbgQRVCzWr0InH9DSlriSetQ Cn/497X6Y/gIMuTZukMYtaFMMcJ/s/jbLRoDhgu53IUzIT0fTyC/6Y3z0Xcvo/r/ wv5wVJUCLqUxkIH1sYHO4Y80fhlBq/h8O5U3APg+FR3IRtdRWUgk9hr/yridLXDj AYL9OfyKagEQ4kNALukseFstAhxZ5eaSjyzA3AKmLHSI/pIpnrihvyarsHnx9cPZ Cb0ooHtABGRcQA8px+tWeAUP7WQtS70QSyGfhaDUWCD599gAbKnWfuac6r3RigzC VKUzgs9qskpj77cVGnsS+Wukjnfh9q3xTgbeIWcM/9KKwt3wjiZEtrQSwt52zraZ EzLcqsT06g2/uH0UXjN0iv0HTvzI6ueN4BHyQR6IBNbGn/oDJvKiMUqMAF72w16l aSe/6M0D4nkZnsrr5eFcAbuXpTLH8Y1LKNicZoh9fo0vkDLlfw4= =qJm2 -----END PGP SIGNATURE----- --7rautxzl4pxhcleu--