unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ng0 <ng0@n0.is>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [bug#29708] Update s-shell
Date: Thu, 14 Dec 2017 17:38:35 +0000	[thread overview]
Message-ID: <20171214173835.u7elrv4lrnlv3mqr@abyayala> (raw)
In-Reply-To: <87efnx8bm4.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

Ludovic Courtès transcribed 0.4K bytes:
> ng0 <ng0@n0.is> skribis:
> 
> > From cf2cbe9e9e525aa9dd697fcedb255a0fbc194ac9 Mon Sep 17 00:00:00 2001
> > From: ng0 <ng0@n0.is>
> > Date: Thu, 14 Dec 2017 13:22:58 +0000
> > Subject: [PATCH] s-shell: Update to commit
> >  da2e5c20c0c5f477ec3426dc2584889a789b1659.
> >
> > * gnu/packages/shells.scm (s-shell): Update to commit da2e5c20c0c5f477ec3426dc2584889a789b1659.
> > (version): Use 'git-version'.
> 
> I adjusted the commit log and pushed.

Why is it [version]? Shouldn't it be (version)?
Even though [version] now makes sense, I've seen
mostly [] when it followed a () - and that's why
I've been using ()[] and never(?) [] on its own.

I haven't read HACKING or the chapter 'Contributing' in a while,
so you might be describing something that's already in there. If
it isn't, does it matter to agree on a fixed grammar for this?
I've come to appreciate the strong QA and checks, but what matters
is the content of the brackets, not the chosen form of brackets.
For ()[] it makes sense.

> Thanks!
> 
> Ludo’.
> 

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

       reply	other threads:[~2017-12-14 17:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20171214133123.ymo5dxscjqhsbkfn@abyayala>
     [not found] ` <87efnx8bm4.fsf@gnu.org>
2017-12-14 17:38   ` ng0 [this message]
2017-12-16  5:30     ` [bug#29708] Update s-shell 宋文武
2017-12-16  9:09       ` ng0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214173835.u7elrv4lrnlv3mqr@abyayala \
    --to=ng0@n0.is \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).