On Tue, Dec 05, 2017 at 12:57:59PM +0100, Mark Meyer wrote: > I tried enabling test, but sometimes it's easiest to just ask, from the > Krita IRC channel: > > 12:49 < ofosos> hey, I'm trying to package Krita for Guix and I'm > getting a lot > errors, when I activate the check phase of the build. > Are these > tests supposed to pass in a release tarball? I have to > add that > I set "QT_QPA_PLATFORM" "offscreen" to facilitate tests > running > at all > 12:50 -!- salamanderrake > [~quassel@2605:a000:122a:32:89c6:d481:6fca:1d06] has > quit [Remote host closed the connection] > 12:52 -!- NullConstant [~quassel@5.172.232.196] has joined #krita > 12:55 < scottyp_mobile> a lot of unit tests fail in general right now. > no one > has had time to maintain those ofosos > 12:55 < ofosos> scottyp_mobile: is this true of the release tarballs? > then I > would simply disable the check phase > 12:56 < scottyp_mobile> this is just true in general > 12:56 < scottyp_mobile> you could try to disable them > > Looks like tests won't work anyways. So the patch can't be improved in > this regard. > > Cheers, Mark > It looks like Debian disables the tests¹, as does Arch². ¹ https://sources.debian.org/src/krita/1:3.3.2.1+dfsg-1/debian/rules/#L28 ² https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/krita#n31 -- Efraim Flashner אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted