unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Bavier <ericbavier@centurylink.net>
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org
Subject: Re: avoid wrapper scripts when possible
Date: Sat, 4 Nov 2017 16:42:43 -0500	[thread overview]
Message-ID: <20171104164243.12c81e3d@centurylink.net> (raw)
In-Reply-To: <20171103185416.0ffc4065@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 1698 bytes --]

On Fri, 3 Nov 2017 18:54:16 +0000
Christopher Baines <mail@cbaines.net> wrote:

> However, I think that the file wrapping approach has advantages for
> visibility. Maybe it could be tweaked to keep ensure the wrapper script
> has the same name as the script its wrapping, e.g. when wrapping foo,
> replace foo with a bash script, and move the real script
> to .wrapped-bin/foo.

We already try to do just that, by using the -a flag when exec'ing the
real program from the wrapper.  But...

> the environment activation feature of our “conda” package currently
> fails.  This is because the “deactivate” shell script is wrapped in
> another shell script.  This leads to the actual shell script to be
> called “.deactivate-real”.  The script compares the value of “$0” with
> the expected name “deactivate”.  This fails so conda misbehaves.

... it doesn't behave correctly when the "real" program is
shebang-interpreted.  It works fine for compiled programs.  

E.g. our "emacs-25.3" is a wrapper that sets XDG and GTK env vars, but
top/htop/ps show the proper "emacs-25.3".  OTOH we have the
"deactivate" example from Ricardo, which is a shell script, and e.g.
youtube-dl, whose --help output includes "Usage: .youtube-dl-real ...".

So the interpreters are not passing on the intended zeroth argument.

IMHO it'd be nice to find some way to fix that.  A while ago I had
looked into patching Perl libraries/programs.  But like Hartmut
mentioned for python, I noticed after some research that patching perl
paths would be nontrivial, and would require a perl parser to determine
where and how to patch the library paths correctly.

2c,
`~Eric

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-11-05  2:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 21:31 avoid wrapper scripts when possible Ricardo Wurmus
2017-11-03 18:54 ` Christopher Baines
2017-11-03 19:22   ` Jan Nieuwenhuizen
2017-11-03 21:17   ` Ricardo Wurmus
     [not found]     ` <874lqbghlz.fsf@elephly.net>
2017-11-03 22:41       ` Ricardo Wurmus
2017-11-05 11:10     ` Hartmut Goebel
2017-11-04 21:42   ` Eric Bavier [this message]
2017-11-04 10:12 ` Hartmut Goebel
     [not found]   ` <87tvy9ptge.fsf@elephly.net>
2017-11-05 11:00     ` Hartmut Goebel
2017-11-05 17:06       ` Ludovic Courtès
2017-11-06 15:53 ` Dave Love
  -- strict thread matches above, loose matches on Subject: below --
2021-09-07 18:52 Attila Lendvai
2021-09-07 20:41 ` Maxime Devos
2021-09-08  9:20   ` Attila Lendvai
2021-09-08 10:39     ` Maxime Devos
2021-09-24 21:38 John Kehayias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171104164243.12c81e3d@centurylink.net \
    --to=ericbavier@centurylink.net \
    --cc=guix-devel@gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).