unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: Upgrading packages with substitutes only (bug #26608)
Date: Sun, 18 Jun 2017 12:11:03 -0400	[thread overview]
Message-ID: <20170618161103.GB30146@jasmine.lan> (raw)
In-Reply-To: <87injt7hzu.fsf@elephly.net>

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

On Sun, Jun 18, 2017 at 11:38:45AM +0200, Ricardo Wurmus wrote:
> 
> Ludovic Courtès <ludo@gnu.org> writes:
> 
> > BTW, should --only-substitutes filter out packages without a substitute,
> > or should it simply stop and report the list of missing substitutes
> > (after which the user could use --do-not-upgrade)?

I like making it return a list on stdout so it can be composed as
suggested.

> In my opinion “--only-substitutes” should stop and report a list.
> If it continued without complaining there could be problems:
> 
> * partial upgrades could leave the profile in an unusable state
> 
> * an attacker could use this to trick a user into thinking that they
>   have all available updates
> 
> On the other hand, it would make “--only-substitutes” less usable,
> because to actually perform work one would have to deal with the failure
> case.
> 
> I suppose it could download the substitutes but not build a new profile
> and report an error at that point.

Perhaps there could be an additional flag --partial-upgrade to make it
build a new profile.

I understand why people want --only-substitutes but I'm a bit wary of it
for the reasons you gave, and I think we should solve their complaint by
improving our build infrastructure.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-06-18 16:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16 19:28 Upgrading packages with substitutes only (bug #26608) Timothy Sample
2017-06-17 22:34 ` Ludovic Courtès
2017-06-18  9:38   ` Ricardo Wurmus
2017-06-18 16:11     ` Leo Famulari [this message]
2017-06-18 17:44       ` Timothy Sample
2017-06-18 21:44         ` Ricardo Wurmus
2017-06-19  0:23         ` Carlo Zancanaro
2017-06-19 17:33         ` Leo Famulari
2017-06-19 12:02     ` Ludovic Courtès
2017-06-19 17:25       ` Timothy Sample

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170618161103.GB30146@jasmine.lan \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).