From: Leo Famulari <leo@famulari.name>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: Switching to Artifex Ghostscript
Date: Tue, 30 May 2017 00:40:24 -0400 [thread overview]
Message-ID: <20170530044023.GA9717@jasmine> (raw)
In-Reply-To: <87poerz1sl.fsf@netris.org>
[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]
On Mon, May 29, 2017 at 07:22:18PM -0400, Mark H Weaver wrote:
> > Leo Famulari <leo@famulari.name> writes:
> >
> >> + (replace 'build
> >> + (lambda _
> >> + ;; Build 'libgs.so', but don't build the statically-linked 'gs'
> >> + ;; binary (saves 22 MiB).
> >> + (zero? (system* "make" "so" "-j"
> >> + (number->string
> >> (parallel-job-count))))))
> >
> > Couldn’t we just add “#:make-flags '("so")” and avoid replacing the
> > build phase?
>
> FWIW, I think it's a bad habit to abuse #:make-flags for targets,
> because the contents of #:make-flags is also passed to 'make' during the
> 'install' and 'check' phases.
That's a good point. For this package I think we can just re-use the
build phase replacement from the GNU Ghostscript package, as in v1 of my
patch.
> IMO, if we want to avoid replacing the build phase in cases like this,
> it would be better to add a separate #:build-target argument.
>
> Thoughts?
Yes, it could be useful.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-05-30 4:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 20:55 Switching to Artifex Ghostscript Leo Famulari
2017-05-20 21:53 ` Marius Bakke
2017-05-21 13:06 ` Ricardo Wurmus
2017-05-23 17:39 ` Leo Famulari
2017-05-26 12:02 ` Ricardo Wurmus
2017-05-23 20:42 ` Ludovic Courtès
2017-05-29 17:50 ` Leo Famulari
2017-05-29 18:33 ` Leo Famulari
2017-05-29 18:38 ` Ricardo Wurmus
2017-05-29 20:47 ` Leo Famulari
2017-05-29 22:14 ` Leo Famulari
2017-06-02 16:26 ` Leo Famulari
2017-06-02 18:16 ` Leo Famulari
2017-06-03 13:55 ` Ludovic Courtès
2017-05-29 23:22 ` Mark H Weaver
2017-05-30 4:40 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530044023.GA9717@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).