From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petter Subject: Re: [PATCH] gnu: Add Xfce Notification Daemon. Date: Mon, 24 Apr 2017 20:54:41 +0200 Message-ID: <20170424205441.4a05740c@mykolab.ch> References: <20170421153745.36c3b05c@mykolab.ch> <20170424171933.5072c441@mykolab.ch> <87o9vlzukr.fsf@fastmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/pYFXg.VboXh9h2BoX04r0S."; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2j8a-0002t3-MR for guix-devel@gnu.org; Mon, 24 Apr 2017 14:55:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2j8U-0001p0-2D for guix-devel@gnu.org; Mon, 24 Apr 2017 14:55:02 -0400 Received: from mx.kolabnow.com ([95.128.36.1]:6968 helo=mx-out03.mykolab.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d2j8T-0001np-Ra for guix-devel@gnu.org; Mon, 24 Apr 2017 14:54:58 -0400 In-Reply-To: <87o9vlzukr.fsf@fastmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --Sig_/pYFXg.VboXh9h2BoX04r0S. Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hei Marius, > > + (native-inputs > > + `(("intltool" ,intltool) > > + ("pkg-config" ,pkg-config))) > > + (propagated-inputs > > + `(("glib:bin" ,glib "bin"))) =20 >=20 > Do you know why glib:bin needs to be propagated here? Looking at > gnome.scm, it's usually a "native-input". If this program requires > some of the executables from that package at runtime, it's better to > patch it with the absolute paths. I don't know. I just saw it done like this in another package in xfce.scm. Reading up on inputs I see propagated-inputs "will be installed alongside the package they belong to". Yeah, let's see if we can avoid that. I've adjusted the recipe to test with glib:bin as a native-input, it builds fine, and a quick remove and install shows no issues either. However, the notification system still worked with it removed, so I'm not certain the new one is the one used. I will test this further next time I boot my system. > Other than that looks great! I'd add an @code{...} wrapper around > "org.freedesktop.Notifications" in the description, but that can be > fixed up before committing, no need for a new patch. I'll make sure to add this if I produce a new patch. Thanks for the feedback! Best, Petter --Sig_/pYFXg.VboXh9h2BoX04r0S. Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEB+Ude/iUmL3PehPCvgTmz6aYnSEFAlj+SfEACgkQvgTmz6aY nSEqcxAAheCV8SxcOjkMb4T2RZ3ebFC/zJajp6JHoCGVM0BSYPYzMkS2d7iADeME 4Q3Et9g8Ao4kDz0xYp7DsDqd/CZQskluKGVAYBr2fNZO5FZYXo03LRr7SlLwLKkV OtDXMe9qlJ6AQ7i3j8/cPXlq1rlCDsvHZL0YRMJpqWPOd4UUFBClWGxSSGaMIjsg Ip0ZGPYPH6S+e9IyoAXm/Ro+F8EyX+OOqZQzLeLwcHWwp3FbBiP/cq1yxUsSNopg /VhbxjX99/FwBXz1GS/x25dmG9FRc6ixB2HHt5MBiKW/e698dogqDhDf7Vtjibsi 4deXKcwD2H4IxI7g1wEKwluFIUA6VhITGwG1lpg6gpc7BC8vgBREmkdi3ueB01NR Qjvn4tO/RtHitMMK5PfAt3hxqtiYBeWG6nHDiYFnBuoY+wuEdIBb0PveNdGCQDca +dPoMqTG/NvdIFwE+prbqV7OrGs4GdzDNK/XTKGb27PNflRG0dMr6lo4aGuPb5wT IdrzUcYtZQUkoUILT4wGgNOF0CcRsrmZ7BuxusFo+K2fFCR88pnEej2CtZ9vYpMU LJR3zjsbct54x8fYIEfh51PynPorSf/HkPAOzuY0qUBeDSEuwwEkBrSnVrTKiHQE RuuLfGNfPFt3I1jykBsNRqF9Bd0wU/vxFl1IwP6fyvOuX++hHkY= =k4nO -----END PGP SIGNATURE----- --Sig_/pYFXg.VboXh9h2BoX04r0S.--