From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 05/20] gnu: Add python-sphinx-1.3.3 Date: Mon, 17 Apr 2017 15:15:03 -0400 Message-ID: <20170417191503.GB28022@jasmine> References: <20170414101320.11755-1-fredmanglis@gmail.com> <20170414101320.11755-5-fredmanglis@gmail.com> <762b98ae-9bd5-4549-abc6-2810dd997213@goebel-consult.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gj572EiMnwbLXET9" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0C7G-0004cu-AC for guix-devel@gnu.org; Mon, 17 Apr 2017 15:15:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0C76-0005Rd-FK for guix-devel@gnu.org; Mon, 17 Apr 2017 15:15:09 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34549) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d0C76-0005RW-Bh for guix-devel@gnu.org; Mon, 17 Apr 2017 15:15:04 -0400 Content-Disposition: inline In-Reply-To: <762b98ae-9bd5-4549-abc6-2810dd997213@goebel-consult.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel Cc: guix-devel@gnu.org --gj572EiMnwbLXET9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 15, 2017 at 07:38:57PM +0200, Hartmut Goebel wrote: > Am 15.04.2017 um 19:28 schrieb Hartmut Goebel: > > Am 14.04.2017 um 12:13 schrieb Muriithi Frederick Muriuki: > >> (define-public python2-sphinx-rtd-theme-0.1.9 > >> (package-with-python2 python-sphinx-rtd-theme-0.1.9)) > >> + > >> +(define-public python-sphinx-1.3.3 > >> + ;; python-httpretty has a hard requirement for > >> + ;; sphinx =3D=3D 1.3.3 > > Please test if it works with an up-to-date version of sphinx, too. There > > are very few reasons for requiring strict version of a tool like sphinx > > or sphinx-rtd-them. And we should avoid adding versions over versions of > > packages. > https://github.com/gabrielfalcao/HTTPretty/blob/0.8.14/requirements.txt > says: >=20 > # HTTPretty doesn't have any requirements per se so far. yay! >=20 > So I assume you take the version definitions in "development.txt" as > "hard requirement" - but this file only defines *one* valid set of > dependencies. So please review *all* the packages you say > "python-httpretty has a hard requirement" and try to get rid of them. It > may be even better to patch or "substitute" httpretty to make it work > with our set of versions instead of piling of version of packages used > only for this one. Thanks. I agree, it would be best if we could avoid collecting many versions of packages like Sphinx; it will become a pain to maintain them later. On the other hand, it is also a burden to maintain patches against upstream code. Both approaches cost human time and energy. Personally, I think it's up to Frederick how he decides to handle this, since he will be maintaining these packages in the future :) --gj572EiMnwbLXET9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlj1FDYACgkQJkb6MLrK fwiXxxAA5xt5M2gUhPtxSpU0lAFL2jmmVw8e1hwiwfZn9JFVQJZ9+H0lE66q4nDw mYH8M5bJxjo7b5UhIzfyb5dQuK83uJ32H/5TaJnabXrd71XraCG1xzGz+o4AveZI e78C5PiPYFaX2deC4ddLn6MCRZ4pG4A5GsTKljBXAlMJmpLhZbyyvoVAhwbDibD6 lv/QQ5Vio/sJTcjn+oakp8pE3y/cr1f/68vWeWcECleHogWXs95tVj0UhK/oQHnw uBpn6gBOdzKYnLGbwjU0W2E1k/3Y6F7Qf9fPbp77EAQay+MQIvwfmCydRRDsMevN RoLQNgWhQiOb38Oz7jN3rI70097R1proCUrrbQCrQeP3EPoHY1BaECkuit+UABjA pdO5ira7qs6YOBcsK4HKB50zelxVJylAZqdFy3MX1BxRqEUU80AnitvqLlmnxmTc 9YATVTcL8QZmbzICvb4s9fJVBpQ/PwyhqBRFtRfWuhHp6zbroTGlVex83VtNvvV3 0bjiSPa0DBSW7O7OTwoVBFVVhY+kW86vmMlx/50xD5+76s+ni9v/PLmXU8kg2bg+ fyK17TcExUprxW0gZFcKWkuTxDAbEBw4uMAvyIzR28+8QjA+Tq1dSHtnMC93QMEU GVoeeyLi66RO3GJU274UxIBtD0L4IeJR0yMW2kVBD5moUhxCBG4= =4XBu -----END PGP SIGNATURE----- --gj572EiMnwbLXET9--