From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Trofimovich Subject: Re: [PATCH] gnu: go: Update to 1.8.1 Date: Mon, 17 Apr 2017 13:54:18 +0100 Message-ID: <20170417135418.0bf12c87@sf> References: <7f4cf1ee6c558899e8c9457102c2e0d4@mykolab.ch> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/DvgAa2Mw6=KxD9k6K5n4LYQ"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d06Ay-0004Lx-VG for guix-devel@gnu.org; Mon, 17 Apr 2017 08:54:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d06Aw-0001dZ-CK for guix-devel@gnu.org; Mon, 17 Apr 2017 08:54:41 -0400 Received: from smtp54.i.mail.ru ([217.69.128.34]:60334) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d06Av-0001a2-Vt for guix-devel@gnu.org; Mon, 17 Apr 2017 08:54:38 -0400 In-Reply-To: <7f4cf1ee6c558899e8c9457102c2e0d4@mykolab.ch> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Petter Cc: guix-devel@gnu.org --Sig_/DvgAa2Mw6=KxD9k6K5n4LYQ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 17 Apr 2017 14:16:06 +0200 Petter wrote: > Hi, >=20 > With this patch I'm not sure how to properly handle Copyright. I've=20 > taken a guess and prepared a > patch anyway. >=20 > Here's the situation. >=20 > Updating to 1.8 was not trivial. A fix has been posted in a comment by=20 > Sergei Trofimovich on > github[1]. It's a proper Guix patch, updating Go to 1.8, with the fix=20 > and the trivial update stuff, > but as far as I can see not actually submitted to Guix. >=20 > [1] https://github.com/golang/go/issues/19132#issuecomment-285897612 >=20 > After this Go 1.8.1 has been released. The attached patch has the=20 > trivial update stuff for 1.8.1 > and the fix by Sergei. I added Sergei to the Copyright section, but I'm=20 > not sure if this is > correct, and if this is the way to do it. Also, I didn't find his e-mail= =20 > address, so I just added > his github page, in ()... >=20 > A little messy, please let me know if I should do something differently. I consider the fix itself trivial thus I'm perfectly fine with not being attributed at all. Apologies for making it hard to track me down. I've added one of emails to github's front page. [ While the fix is trivial debugging was a bit more fun :) ] If you still like to add attribution (or have other reasons) feel free to add "Sergei Trofimovich " I didn't get to submitting something that works because some unrelated go-1.8.0 tests failed for me. go-1.8.1 fails in a similar way, but if it works for you it's very probable just my environment (x86_64-linux): guix-master $ ./pre-inst-env guix build go-1.8 ##### ../misc/cgo/test runtime/cgo: pthread_create failed: Resource temporarily unavailable scatter =3D 0x55ffc0 hello from C sqrt is: 0 SIGABRT: abort PC=3D0x7ffff71232c4 m=3D12 sigcode=3D18446744073709551610 Thanks for finishing go update! --=20 Sergei --Sig_/DvgAa2Mw6=KxD9k6K5n4LYQ Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSZKa0VG5avZRlY01hxoe52YR/zqgUCWPS6+gAKCRBxoe52YR/z qnjGAJ99vZnL2BQ9aYMp3dwcr/NL+LTWEACdGlxhzotD8UBfURHgjMA9HpqkOek= =l3X/ -----END PGP SIGNATURE----- --Sig_/DvgAa2Mw6=KxD9k6K5n4LYQ--