From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: problem with commit abae042
Date: Sat, 15 Apr 2017 20:56:31 +0200
Message-ID: <20170415205631.46af6c48@scratchpost.org>
References: <20170402135242.2958-1-m.othacehe@gmail.com>
	<20170402135242.2958-17-m.othacehe@gmail.com>
	<20170415184756.10b178be@scratchpost.org>
	<871sstilgo.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54852)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1czSsG-00008M-20
	for guix-devel@gnu.org; Sat, 15 Apr 2017 14:56:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1czSsD-0006Ry-1m
	for guix-devel@gnu.org; Sat, 15 Apr 2017 14:56:44 -0400
Received: from dd1012.kasserver.com ([85.13.128.8]:43864)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1czSsC-0006Py-RT
	for guix-devel@gnu.org; Sat, 15 Apr 2017 14:56:40 -0400
In-Reply-To: <871sstilgo.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26339@debbugs.gnu.org, guix-devel <guix-devel@gnu.org>

Hi,

On Sat, 15 Apr 2017 20:17:59 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:

> I think there's a problem with commit abae042 :
> 
> * profile-grub-entries become unused and is still present.

I know, I can't remove it without review, far too dangerous.

> * When using switch-generation, operating-system-bootcfg is not
> * called. So, the kernel arguments are not correctly set (--root,
> * --system and --load), and the resulting entries in grub.cfg are broken.

Yes, indeed.  I'm working on it.  If I can't get it to work today I'll back it out again.

Too bad this is such a huge changeset - it's quite difficult to find a safe path.

Do you have an idea how to fix it? 

Would it be good to press forward with the other patches or should I back it out?