From: Danny Milosavljevic <dannym@scratchpost.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26339@debbugs.gnu.org, guix-devel <guix-devel@gnu.org>
Subject: Re: problem with commit abae042
Date: Sat, 15 Apr 2017 20:56:31 +0200 [thread overview]
Message-ID: <20170415205631.46af6c48@scratchpost.org> (raw)
In-Reply-To: <871sstilgo.fsf@gmail.com>
Hi,
On Sat, 15 Apr 2017 20:17:59 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:
> I think there's a problem with commit abae042 :
>
> * profile-grub-entries become unused and is still present.
I know, I can't remove it without review, far too dangerous.
> * When using switch-generation, operating-system-bootcfg is not
> * called. So, the kernel arguments are not correctly set (--root,
> * --system and --load), and the resulting entries in grub.cfg are broken.
Yes, indeed. I'm working on it. If I can't get it to work today I'll back it out again.
Too bad this is such a huge changeset - it's quite difficult to find a safe path.
Do you have an idea how to fix it?
Would it be good to press forward with the other patches or should I back it out?
next prev parent reply other threads:[~2017-04-15 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170402135242.2958-1-m.othacehe@gmail.com>
[not found] ` <20170402135242.2958-17-m.othacehe@gmail.com>
[not found] ` <20170415184756.10b178be@scratchpost.org>
2017-04-15 18:17 ` problem with commit abae042 Mathieu Othacehe
2017-04-15 18:56 ` Danny Milosavljevic [this message]
2017-04-15 19:13 ` Mathieu Othacehe
2017-04-15 19:50 ` bootloader and kernel arguments "--root", "--system", "--load" Danny Milosavljevic
2017-04-15 23:18 ` bug#26339: problem with commit abae042 Leo Famulari
2017-04-15 23:22 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170415205631.46af6c48@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=26339@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).