Re: ld-wrapper is broken in core-updates due to guile-2.2 (host running guile-2.0)

[Sergei Trofimovich <slyfox@inbox.ru>]

[-- Attachment #1: Type: text/plain, Size: 3617 bytes --]

On Fri, 14 Apr 2017 21:59:47 +0100
Sergei Trofimovich <slyfox@inbox.ru> wrote:

> Efraim noticed core-updates breakage on package libgpg-error.
> 
> TL;DR:
> 
>   ld-wrapper package embeds guile-2.2 interpreter
>   to interpret ld.go bytecode built by guile-2.0.
>   I have no idea how to fix it but still decided to
>   share my findings so far.

Confirmed guile-2.2 is triggering failure:

reverting commit 34d624cef51f0e4eb4e888622b60fc2befe31fa7
("gnu: Build derivations with Guile 2.2 by default.") fixes libgpg-error build.

Another less obvious problem caused by guile-2.2 is triggered in bash-static:

  guix-core-updates $ ./pre-inst-env guix build bash-static
  The following derivation will be built:
     /gnu/store/hr3g5avmb9fmgr047990r9mc6gmnq674-bash-static-4.4.12.drv
  @ build-started /gnu/store/hr3g5avmb9fmgr047990r9mc6gmnq674-bash-static-4.4.12.drv - x86_64-linux /var/log/guix/drvs/hr//3g5avmb9fmgr047990r9mc6gmnq674-bash-static-4.4.12.drv.bz2
  ice-9/psyntax.scm:1534:32: In procedure expand-macro:
  ice-9/psyntax.scm:1534:32: Syntax error:
  /gnu/store/bc7pyl426zaa2489qp97bqaycv2ir2v1-bash-static-4.4.12-guile-builder:1:2300: source expression failed to match any pattern in form (%modify-phases phases* (delete (quote move-development-files)))
  builder for `/gnu/store/hr3g5avmb9fmgr047990r9mc6gmnq674-bash-static-4.4.12.drv' failed with exit code 1
  @ build-failed /gnu/store/hr3g5avmb9fmgr047990r9mc6gmnq674-bash-static-4.4.12.drv - 1 builder for `/gnu/store/hr3g5avmb9fmgr047990r9mc6gmnq674-bash-static-4.4.12.drv' failed with exit code 1
  guix build: error: build failed: build of `/gnu/store/hr3g5avmb9fmgr047990r9mc6gmnq674-bash-static-4.4.12.drv' failed

It looks like guile-2.2 has different syntax checking rules which
is triggered by the following modify-phases call site:

[ http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/bash.scm#n204 ]
  ...
         ((#:phases phases)
          `(modify-phases ,phases
             ;; No loadable modules.
             (delete 'move-development-files))))))))

[ http://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/utils.scm#n550 ]
  ...
  (define-syntax-rule (modify-phases phases mod-spec ...)
    "Modify PHASES sequentially as per each MOD-SPEC, which may have one of the
  following forms:

    (delete <old-phase-name>)
    (replace <old-phase-name> <new-phase>)
    (add-before <old-phase-name> <new-phase-name> <new-phase>)
    (add-after <old-phase-name> <new-phase-name> <new-phase>)

  Where every <*-phase-name> is an expression evaluating to a symbol, and
  <new-phase> an expression evaluating to a procedure."
    (let* ((phases* phases)
           (phases* (%modify-phases phases* mod-spec))
           ...)
      phases*))

  (define-syntax %modify-phases
    (syntax-rules (delete replace add-before add-after)
      ((_ phases (delete old-phase-name))
       (alist-delete old-phase-name phases))
      ((_ phases (replace old-phase-name new-phase))
       (alist-replace old-phase-name new-phase phases))
      ((_ phases (add-before old-phase-name new-phase-name new-phase))
       (alist-cons-before old-phase-name new-phase-name new-phase phases))
      ((_ phases (add-after old-phase-name new-phase-name new-phase))
       (alist-cons-after old-phase-name new-phase-name new-phase phases))))

CCed Andy in case it's an obvious bug in guix or guile syntax rewriter.

Reverting commit 34d624cef51f0e4eb4e888622b60fc2befe31fa7
("gnu: Build derivations with Guile 2.2 by default.") fixes bash-static as well.

-- 

  Sergei

[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]