From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH 01/20] gnu: Add python-radon Date: Fri, 14 Apr 2017 10:36:54 +0000 Message-ID: <20170414103654.m6n3udlkn6m7rrz3@abyayala> References: <20170414101320.11755-1-fredmanglis@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyybA-0005cU-QH for guix-devel@gnu.org; Fri, 14 Apr 2017 06:37:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyyb8-0001Ft-0Z for guix-devel@gnu.org; Fri, 14 Apr 2017 06:37:04 -0400 Received: from fragranza.investici.org ([178.175.144.26]:28562) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cyyb7-0001FW-MH for guix-devel@gnu.org; Fri, 14 Apr 2017 06:37:01 -0400 Content-Disposition: inline In-Reply-To: <20170414101320.11755-1-fredmanglis@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Muriithi Frederick Muriuki Cc: guix-devel@gnu.org, pjotr2017@thebird.nl Hi, thanks for the patch series. I just have a short advice: Recently, about 2 or 3 months ago, we introduced the guix-patches@gnu.org mailinglist. It has been documented in "CONTRIBUTING= " chapter of the handbook/documentation and in "HACKING" (toplevel file). This has lead to making the guix-devel@gnu.org list a list for discussions concerning the development. It's not bad that you've sent the patches here, but for the next time opening a bug ticket and sending them there will be prefered. It also introduces the possibility to track the patches so that they don't get lost. Thanks! Muriithi Frederick Muriuki transcribed 2.0K bytes: > * gnu/packages/python.scm (python-radon): New variable. > --- > gnu/packages/python.scm | 40 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 39 insertions(+), 1 deletion(-) >=20 > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index 231c629..23b6d86 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -13950,7 +13950,7 @@ recognize TestCases.") > (package-with-python2 python-mando)) > =20 > (define-public python-mando-0.3.1 > - ;; python-radon (version 1.5.0) has a requirement > + ;; python-radon has a requirement > ;; for mando<0.4,>=3D0.3 > (package > (inherit python-mando) > @@ -13965,3 +13965,41 @@ recognize TestCases.") > (sha256 > (base32 > "17jlkdpqw22z1nyml5ybslilqkzmnk0dxxjml8bfghav1l5hbwd2")))))) > + > +(define-public python-radon > + ;; xenon has a hard requirement for radon>=3D1.4.0,<1.5 > + (package > + (name "python-radon") > + (version "1.4.2") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "radon" version)) > + (sha256 > + (base32 > + "15xyzavfj1zwb5rn07fs2wfi6ccys9b5q0s8hmnpqz712mifl92g")))) > + (build-system python-build-system) > + (propagated-inputs > + `(("python-colorama" ,python-colorama) > + ("python-flake8-polyfill" > + ,python-flake8-polyfill) > + ("python-mando" ,python-mando-0.3.1))) > + (native-inputs > + `(("python-flake8" ,python-flake8) > + ("python-tox" ,python-tox) > + ("python-pytest" ,python-pytest) > + ("python-paramunittest" ,python-paramunittest))) > + (home-page "https://radon.readthedocs.org/") > + (synopsis "Code Metrics in Python") > + (description "Radon is a Python tool which computes various code m= etrics. Supported > + metrics are: > +@itemize @bullet > +@item raw metrics: SLOC, comment lines, blank lines, &c. > +@item Cyclomatic Complexity (i.e. McCabe=E2=80=99s Complexity) > +@item Halstead metrics (all of them) > +@item the Maintainability Index (a Visual Studio metric) > +@end itemize") > + (license license:expat))) > + > +(define-public python2-radon > + (package-with-python2 python-radon)) > --=20 > 2.10.2 >=20 >=20 --=20 PGP and more: https://people.pragmatique.xyz/ng0/