Re: [PATCH 01/20] gnu: Add python-radon

[ng0 <contact.ng0@cryptolab.net>]

Hi,

thanks for the patch series. I just have a short advice:
Recently, about 2 or 3 months ago, we introduced the
guix-patches@gnu.org mailinglist. It has been documented in "CONTRIBUTING"
chapter of the handbook/documentation and in "HACKING" (toplevel file).
This has lead to making the guix-devel@gnu.org list a list for
discussions concerning the development.
It's not bad that you've sent the patches here, but for the next time
opening a bug ticket and sending them there will be prefered. It also
introduces the possibility to track the patches so that they don't get
lost.

Thanks!

Muriithi Frederick Muriuki transcribed 2.0K bytes:
> * gnu/packages/python.scm (python-radon): New variable.
> ---
>  gnu/packages/python.scm | 40 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 39 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 231c629..23b6d86 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -13950,7 +13950,7 @@ recognize TestCases.")
>    (package-with-python2 python-mando))
>  
>  (define-public python-mando-0.3.1
> -  ;; python-radon (version 1.5.0) has a requirement
> +  ;; python-radon has a requirement
>    ;; for mando<0.4,>=0.3
>    (package
>      (inherit python-mando)
> @@ -13965,3 +13965,41 @@ recognize TestCases.")
>         (sha256
>          (base32
>           "17jlkdpqw22z1nyml5ybslilqkzmnk0dxxjml8bfghav1l5hbwd2"))))))
> +
> +(define-public python-radon
> +  ;; xenon has a hard requirement for radon>=1.4.0,<1.5
> +  (package
> +    (name "python-radon")
> +    (version "1.4.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "radon" version))
> +       (sha256
> +        (base32
> +         "15xyzavfj1zwb5rn07fs2wfi6ccys9b5q0s8hmnpqz712mifl92g"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-colorama" ,python-colorama)
> +       ("python-flake8-polyfill"
> +        ,python-flake8-polyfill)
> +       ("python-mando" ,python-mando-0.3.1)))
> +    (native-inputs
> +     `(("python-flake8" ,python-flake8)
> +       ("python-tox" ,python-tox)
> +       ("python-pytest" ,python-pytest)
> +       ("python-paramunittest" ,python-paramunittest)))
> +    (home-page "https://radon.readthedocs.org/")
> +    (synopsis "Code Metrics in Python")
> +    (description "Radon is a Python tool which computes various code metrics.  Supported
> + metrics are:
> +@itemize @bullet
> +@item raw metrics: SLOC, comment lines, blank lines, &c.
> +@item Cyclomatic Complexity (i.e.  McCabe’s Complexity)
> +@item Halstead metrics (all of them)
> +@item the Maintainability Index (a Visual Studio metric)
> +@end itemize")
> +    (license license:expat)))
> +
> +(define-public python2-radon
> +  (package-with-python2 python-radon))
> -- 
> 2.10.2
> 
> 

-- 
PGP and more: https://people.pragmatique.xyz/ng0/