Re: 01/02: gnu: Add itpp.

[John Darrington <john@darrington.wattle.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2848 bytes --]

On Sun, Mar 19, 2017 at 04:46:07PM -0400, Mark H Weaver wrote:
     john@darrington.wattle.id.au (John Darrington) writes:
     
     > jmd pushed a commit to branch master
     > in repository guix.
     >
     > commit a53d6719bc6b6b4afdc58e257ac712df316c8858
     > Author: John Darrington <jmd@gnu.org>
     > Date:   Tue Mar 7 07:51:51 2017 +0100
     >
     >     gnu: Add itpp.
     >     
     >     * gnu/packages/maths.scm (itpp): New variable.
     > ---
     >  gnu/packages/maths.scm | 30 +++++++++++++++++++++++++++++-
     >  1 file changed, 29 insertions(+), 1 deletion(-)
     >
     > diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
     > index adc8156..fe85983 100644
     > --- a/gnu/packages/maths.scm
     > +++ b/gnu/packages/maths.scm
     > @@ -1,7 +1,7 @@
     >  ;;; GNU Guix --- Functional package management for GNU
     >  ;;; Copyright ?? 2013, 2014, 2015, 2016 Andreas Enge <andreas@enge.fr>
     >  ;;; Copyright ?? 2013 Nikita Karetnikov <nikita@karetnikov.org>
     > -;;; Copyright ?? 2014, 2016 John Darrington <jmd@gnu.org>
     > +;;; Copyright ?? 2014, 2016, 2017 John Darrington <jmd@gnu.org>
     >  ;;; Copyright ?? 2014, 2015, 2016 Eric Bavier <bavier@member.fsf.org>
     >  ;;; Copyright ?? 2014 Federico Beffa <beffa@fbengineering.ch>
     >  ;;; Copyright ?? 2014 Mathieu Lirzin <mathieu.lirzin@openmailbox.org>
     > @@ -761,6 +761,34 @@ Swath).")
     >  HDF5 file is encoded according to the HDF File Format Specification.")
     >      (license (license:x11-style "file://COPYING"))))
     >  
     > +(define-public itpp
     > +  (package
     > +    (name "itpp")
     > +    (version "4.3.1")
     > +    (source (origin
     > +              (method url-fetch)
     > +              (uri (string-append "mirror://sourceforge/itpp/itpp/"
     > +                                  version "/itpp-"
     > +                                  version ".tar.gz"))
     > +       (sha256
     > +        (base32
     > +         "14ddy2xnb6sgp4hiax9v5sv4pr4l4dd4ps76nfha3nrpr1ikhcqm"))))
     
     Please be more careful with the indentation above.
     

Do you know - I've been looking carefully at the above for about a minute now, and 
I cannot see anything wrong with the indentation.   I'm not saying that there isn't
anything wrong - but I cannot see it despite close scrutiny.   So I must ask myself:
can we not be a little less strict about indentation?

Anyway Rekado has made me aware of emacs-guix and of etc/indent-code.el so maybe I'll
set up a git hook to use that.

J'
     

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]