From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option. Date: Thu, 16 Mar 2017 20:45:27 +0000 Message-ID: <20170316204527.lnkgc2vot4uqk633@abyayala> References: <20170219185431.zgn53ndcbpedrgo7@wasp> <20170220235355.29115-1-clement@lassieur.org> <20170220235355.29115-5-clement@lassieur.org> <20170302084448.2ff6ce96@scratchpost.org> <87fuivxukg.fsf@lassieur.org> <20170305145026.zgoayn46kvpz5ksy@abyayala> <20170307214959.16038114@scratchpost.org> <87r3284x8s.fsf@lassieur.org> <87h92t1qts.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cobCe-0002ET-4l for guix-devel@gnu.org; Thu, 16 Mar 2017 15:36:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cobCb-0008NN-J3 for guix-devel@gnu.org; Thu, 16 Mar 2017 15:36:52 -0400 Content-Disposition: inline In-Reply-To: <87h92t1qts.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org, =?utf-8?Q?Cl=C3=A9ment?= Lassieur Ludovic Court=C3=A8s transcribed 1.1K bytes: > Hi Cl=C3=A9ment, >=20 > Cl=C3=A9ment Lassieur skribis: >=20 > > I think there is a misunderstanding. I didn't want to push this beca= use > > it was not tested, and because subsystems are often useless without > > Match, and Match is unsupported. The pair/list thing is not the > > problem. > > > > And I was waiting for ng0 to test, because he asked for this patch (s= ee > > http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), = so > > I thought he was able to test. > > > > If ng0 still needs the patch and confirms that it works well, I'm > > willing to update it. Otherwise, let's drop it. >=20 > The patch looks like a useful addition. It would be sad to drop it, no= ? >=20 > If you could add a test to (gnu tests ssh) that would be perfect, but > otherwise it LGTM. Perhaps the default value for =E2=80=98subsystems=E2= =80=99 should > include internal-sftp though, as users probably expect sftp to just wor= k. >=20 > I don=E2=80=99t have any issue with using two-element lists; I think th= e syntax > for pairs can be a bit confusing for newcomers to it=E2=80=99s probably= better > to avoid it in service configuration. >=20 > Thanks, > Ludo=E2=80=99. >=20 I'm taking a break currently and only deal with planing things or documenting work and future Guix related work, so I won't test this in the next 1 or 2 weeks. I am fairly sure that sshfs still needs this. ps Cl=C3=A9ment: 'them'/'they' are pronouns if you don't know the gender = and/or prefered pronoun of a person :)