unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: guix-devel@gnu.org, rennes@openmailbox.org
Subject: Re: [PATCH] gnu: grep: Fix for gnulib library.
Date: Mon, 13 Mar 2017 10:31:03 +0200	[thread overview]
Message-ID: <20170313083103.GF27857@macbook42.flashner.co.il> (raw)
In-Reply-To: <45ea0fec-4129-f996-9022-c3358241c1c9@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1679 bytes --]

On Sat, Mar 11, 2017 at 05:37:13PM +0200, Manolis Ragkousis wrote:
> Hello Ludo,
> 
> On 03/11/2017 01:31 PM, Ludovic Courtès wrote:
> > Hi!
> > 
> > rennes@openmailbox.org skribis:
> > 
> >> From f76585a44afdc41187df768eec79fb723713cf0c Mon Sep 17 00:00:00 2001
> >> From: rennes <rennes@openmailbox.org>
> >> Date: Tue, 21 Feb 2017 23:21:49 -0600
> >> Subject: [PATCH] gnu: grep: Fix for gnulib library.
> >>
> >> * gnu/packages/patches/grep-gnulib-lock.patch: New file.                                                  
> >> * gnu/local.mk (dist_patch_DATA): Add it.
> > 
> > Looks like we missed this ‘core-updates’ cycle.  :-/
> > 
> > To apply it without triggering a full rebuild, you could instead add a
> > phase that invokes ‘patch’ to apply it, only when the cross-compilation
> > target or system is GNU/Hurd.
> > 
> > Like:
> > 
> >   ,@(if (gnu/hurd?)
> >         `((add-before 'configure 'patch …))
> >         '())  ;nothing
> > 
> > Could you try that?
> 
> Even though this would work, maybe we should wait for the next
> core-updates circle in order to avoid more (if (hurd)..) patches.
> 
> Rene WDYT?
> 
> Manolis
> 

more (if (hurd ...)) patches does also make it easier to merge in
changes for those not using hurd when the time comes, and it allows
those actively using hurd to make changes to more low-level packages
without worrying about how it affects the other architectures/kernels.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-03-13  8:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22 12:59 [PATCH] gnu: grep: Fix for gnulib library rennes
2017-03-11 11:31 ` Ludovic Courtès
2017-03-11 15:37   ` Manolis Ragkousis
2017-03-11 15:56     ` rennes
2017-03-13  8:27       ` Ludovic Courtès
2017-04-08 16:14         ` Manolis Ragkousis
2017-03-13  8:31     ` Efraim Flashner [this message]
2017-03-13  8:35       ` Manolis Ragkousis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170313083103.GF27857@macbook42.flashner.co.il \
    --to=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    --cc=manolis837@gmail.com \
    --cc=rennes@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).