Re: 16/16: utils: Make sure to use the right 'bytevector->string'.

Re: 16/16: utils: Make sure to use the right 'bytevector->string'.

[Leo Famulari]

On Wed, Mar 08, 2017 at 05:44:35PM -0500, Ludovic Court�s wrote:
> civodul pushed a commit to branch master
> in repository guix.
> 
> commit 7447aa36e16fb77f75df4d3369db9c942615632e
> Author: Ludovic Courtès <ludo@gnu.org>
> Date:   Wed Mar 8 23:39:03 2017 +0100
> 
>     utils: Make sure to use the right 'bytevector->string'.
>     
>     In Guile 2.2, (rnrs io ports) exports 'bytevector->string', which
>     conflicts with that of (ice-9 iconv).
>     
>     * guix/utils.scm: Hide 'bytevector->string' from (rnrs io ports).

Building from a fresh clone of the Git repo, the build fails like this:

Backtrace:
In ice-9/psyntax.scm:
 279: 19 [scan ((#(syntax-object let # ...) (#) (# #) ...)) () ...]
In ice-9/eval.scm:
 411: 18 [eval # ()]
In ice-9/boot-9.scm:
2954: 17 [define-module* (guix pk-crypto) #:filename ...]
2929: 16 [resolve-imports ((# # #) (#) (#) (#) ...)]
2867: 15 [resolve-interface (guix utils) #:select ...]
2792: 14 [#<procedure 145f2a0 at ice-9/boot-9.scm:2780:4 (name #:optional autoload version #:key ensure)> # ...]
3068: 13 [try-module-autoload (guix utils) #f]
2404: 12 [save-module-excursion #<procedure 208d480 at ice-9/boot-9.scm:3069:17 ()>]
3088: 11 [#<procedure 208d480 at ice-9/boot-9.scm:3069:17 ()>]
In unknown file:
   ?: 10 [primitive-load-path "guix/utils" ...]
In ice-9/eval.scm:
 505: 9 [#<procedure 13ab600 at ice-9/eval.scm:499:4 (exp)> (define-module # # ...)]
In ice-9/psyntax.scm:
1106: 8 [expand-top-sequence ((define-module (guix utils) #:use-module ...)) () ...]
 989: 7 [scan ((define-module (guix utils) #:use-module ...)) () ...]
 279: 6 [scan ((#(syntax-object let # ...) (#) (# #) ...)) () ...]
In ice-9/eval.scm:
 411: 5 [eval # ()]
In ice-9/boot-9.scm:
2954: 4 [define-module* (guix utils) #:filename ...]
2929: 3 [resolve-imports (((guix config)) ((srfi srfi-1)) ((srfi srfi-9)) ...)]
2898: 2 [resolve-interface (rnrs io ports) #:select ...]
 771: 1 [for-each #<procedure 1e6cc30 at ice-9/boot-9.scm:2898:20 (binding)> #]
In unknown file:
   ?: 0 [scm-error misc-error #f ...]

ERROR: In procedure scm-error:
ERROR: no binding `bytevector->string' to hide in module (rnrs io ports)
make[2]: *** [Makefile:4933: make-go] Error 1

Re: 16/16: utils: Make sure to use the right 'bytevector->string'.

[Mark H Weaver]

ludo@gnu.org (Ludovic Courtès) writes:

> civodul pushed a commit to branch master
> in repository guix.
>
> commit 7447aa36e16fb77f75df4d3369db9c942615632e
> Author: Ludovic Courtès <ludo@gnu.org>
> Date:   Wed Mar 8 23:39:03 2017 +0100
>
>     utils: Make sure to use the right 'bytevector->string'.
>     
>     In Guile 2.2, (rnrs io ports) exports 'bytevector->string', which
>     conflicts with that of (ice-9 iconv).
>     
>     * guix/utils.scm: Hide 'bytevector->string' from (rnrs io ports).

This broke the build for me with guile-2.0.13.  "make" results in:

ERROR: In procedure scm-error:
ERROR: no binding `bytevector->string' to hide in module (rnrs io ports)
make[2]: *** [Makefile:4940: make-go] Error 1

       Mark

Re: 16/16: utils: Make sure to use the right 'bytevector->string'.

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> civodul pushed a commit to branch master
>> in repository guix.
>>
>> commit 7447aa36e16fb77f75df4d3369db9c942615632e
>> Author: Ludovic Courtès <ludo@gnu.org>
>> Date:   Wed Mar 8 23:39:03 2017 +0100
>>
>>     utils: Make sure to use the right 'bytevector->string'.
>>     
>>     In Guile 2.2, (rnrs io ports) exports 'bytevector->string', which
>>     conflicts with that of (ice-9 iconv).
>>     
>>     * guix/utils.scm: Hide 'bytevector->string' from (rnrs io ports).
>
> This broke the build for me with guile-2.0.13.  "make" results in:
>
> ERROR: In procedure scm-error:
> ERROR: no binding `bytevector->string' to hide in module (rnrs io ports)
> make[2]: *** [Makefile:4940: make-go] Error 1

Fixed in 3104475148af4f355f9ed5728582e79fea8b2c96, sorry!

Ludo’.