From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH -v2 1/2] build: union: Add create-all-directories?
	parameter to union-build
Date: Tue, 7 Mar 2017 21:35:09 +0100
Message-ID: <20170307213509.31c71597@scratchpost.org>
References: <20170307110749.31614-1-huang.ying.caritas@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47104)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1clLpH-0006ml-O6
	for guix-devel@gnu.org; Tue, 07 Mar 2017 15:35:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1clLpD-0002mz-Qg
	for guix-devel@gnu.org; Tue, 07 Mar 2017 15:35:19 -0500
Received: from dd1012.kasserver.com ([85.13.128.8]:38671)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1clLpD-0002ml-Ju
	for guix-devel@gnu.org; Tue, 07 Mar 2017 15:35:15 -0500
In-Reply-To: <20170307110749.31614-1-huang.ying.caritas@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Huang Ying <huang.ying.caritas@gmail.com>
Cc: guix-devel@gnu.org

Hi,

On Tue,  7 Mar 2017 19:07:48 +0800
Huang Ying <huang.ying.caritas@gmail.com> wrote:

> * guix/build/union.scm (union-build): Add create-all-directories? keyword
>   parameter.  To add/remove some files from the directory.

Maybe without "To add/remove some files from the directory." ?

If you'd like to document your new functionality, please update the docstring in the source code - it's not like we read the git log for API documentation.

The source code currently says:

 "Build in the OUTPUT directory a symlink tree that is the union of all
 the INPUTS."

and it could be updated to say:

 "Build in the OUTPUT directory a symlink tree that is the union of all
  the INPUTS.  As a special case, if CREATE-ALL-DIRECTORIES?, creates
  the direct subdirectories in the output directory to make sure the
  user can add to them later."

Otherwise LGTM!