core-updates: GRUB fails to build

core-updates: GRUB fails to build

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 2537 bytes --]

On core-updates, GRUB fails to build like this:

gcc -DHAVE_CONFIG_H -I.  -Wall -W -DGRUB_UTIL=1 -D_FILE_OFFSET_BITS=64 -I./include -DGRUB_FILE=\"grub_script.yy.c\" -I. -I. -I. -I. -I./include -I./include -I./grub-core/lib/libgcrypt-grub/src/  -I./grub-core/lib/minilzo -I./grub-core/lib/xzembed -DMINILZO_HAVE_CONFIG_H -D_FILE_OFFSET_BITS=64 -Wall -W -Wshadow -Wpointer-arith -Wundef -Wchar-subscripts -Wcomment -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wfloat-equal -Wformat-extra-args -Wformat-security -Wformat-y2k -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Wmain -Wmissing-braces -Wmissing-format-attribute -Wmultichar -Wparentheses -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wswitch -Wtrigraphs -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-value  -Wunused-variable -Wwrite-strings -Wnested-externs -Wstrict-prototypes -Wcast-align  -Wextra -Wattributes -Wendif-labels -Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wmissing-field-initializers -Wnonnull -Woverflow -Wvla -Wpointer-to-int-cast -Wstrict-aliasing -Wvariadic-macros -Wvolatile-register-var -Wpointer-sign -Wmissing-include-dirs -Wmissing-prototypes -Wmissing-declarations -Wformat=2 -Werror  -fno-builtin -Wno-undef  -MT libgrubmods_a-grub_script.yy.o -MD -MP -MF .deps-util/libgrubmods_a-grub_script.yy.Tpo -c -o libgrubmods_a-grub_script.yy.o `test -f 'grub_script.yy.c' || echo './'`grub_script.yy.c
./grub-core/script/yylex.l:34:0: error: "yyalloc" redefined [-Werror]
 #define yyalloc(size, scanner)   (grub_malloc((size)))
 ^
grub_script.yy.c:104:0: note: this is the location of the previous definition

 ^
./grub-core/script/yylex.l:35:0: error: "yyfree" redefined [-Werror]
 #define yyfree(ptr, scanner)   (grub_free((ptr)))
 ^
grub_script.yy.c:108:0: note: this is the location of the previous definition

 ^
./grub-core/script/yylex.l:36:0: error: "yyrealloc" redefined [-Werror]
 #define yyrealloc(ptr, size, scanner) (grub_realloc((ptr), (size)))
 ^
grub_script.yy.c:106:0: note: this is the location of the previous definition

 ^
cc1: all warnings being treated as errors
make[2]: *** [Makefile:7590: libgrubmods_a-grub_script.yy.o] Error 1
make[2]: Leaving directory '/tmp/guix-build-grub-2.02rc1.drv-0/grub-2.02~rc1'
make[1]: *** [Makefile:10897: all-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-grub-2.02rc1.drv-0/grub-2.02~rc1'
make: *** [Makefile:3123: all] Error 2
phase `build' failed after 19.0 seconds

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: core-updates: flex is broken [was: GRUB fails to build]

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

On Sat, Mar 04, 2017 at 01:42:34PM -0500, Leo Famulari wrote:
> On core-updates, GRUB fails to build like this:

> ./grub-core/script/yylex.l:34:0: error: "yyalloc" redefined [-Werror]
>  #define yyalloc(size, scanner)   (grub_malloc((size)))
>  ^
> grub_script.yy.c:104:0: note: this is the location of the previous definition
> 
>  ^
> ./grub-core/script/yylex.l:35:0: error: "yyfree" redefined [-Werror]
>  #define yyfree(ptr, scanner)   (grub_free((ptr)))
>  ^
> grub_script.yy.c:108:0: note: this is the location of the previous definition
> 
>  ^
> ./grub-core/script/yylex.l:36:0: error: "yyrealloc" redefined [-Werror]
>  #define yyrealloc(ptr, size, scanner) (grub_realloc((ptr), (size)))
>  ^
> grub_script.yy.c:106:0: note: this is the location of the previous definition
> 
>  ^
> cc1: all warnings being treated as errors

Discussion in the GRUB project; they've decided not to fix this in their
code and to instead wait for it to be fixed in flex:

http://lists.gnu.org/archive/html/grub-devel/2017-02/msg00133.html

flex discussion:

https://github.com/westes/flex/issues/162

So, the flex package on core-updates is not ready to be deployed,
unfortunately :(

We can wait for a flex update or try to port the bug fix.

Any volunteers?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: core-updates: flex is broken [was: GRUB fails to build]

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> On Sat, Mar 04, 2017 at 01:42:34PM -0500, Leo Famulari wrote:
>> On core-updates, GRUB fails to build like this:
>
>> ./grub-core/script/yylex.l:34:0: error: "yyalloc" redefined [-Werror]
>>  #define yyalloc(size, scanner)   (grub_malloc((size)))
>>  ^
>> grub_script.yy.c:104:0: note: this is the location of the previous definition
>> 
>>  ^
>> ./grub-core/script/yylex.l:35:0: error: "yyfree" redefined [-Werror]
>>  #define yyfree(ptr, scanner)   (grub_free((ptr)))
>>  ^
>> grub_script.yy.c:108:0: note: this is the location of the previous definition
>> 
>>  ^
>> ./grub-core/script/yylex.l:36:0: error: "yyrealloc" redefined [-Werror]
>>  #define yyrealloc(ptr, size, scanner) (grub_realloc((ptr), (size)))
>>  ^
>> grub_script.yy.c:106:0: note: this is the location of the previous definition
>> 
>>  ^
>> cc1: all warnings being treated as errors
>
> Discussion in the GRUB project; they've decided not to fix this in their
> code and to instead wait for it to be fixed in flex:
>
> http://lists.gnu.org/archive/html/grub-devel/2017-02/msg00133.html
>
> flex discussion:
>
> https://github.com/westes/flex/issues/162
>
> So, the flex package on core-updates is not ready to be deployed,
> unfortunately :(
>
> We can wait for a flex update or try to port the bug fix.

Any idea how many packages aside from GRUB are affected?  Would it work
to simply provide the old Flex in addition to the new one, and have GRUB
use it?

Thanks,
Ludo’.

Re: core-updates: flex is broken [was: GRUB fails to build]

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

On Mon, Mar 06, 2017 at 11:14:37AM +0100, Ludovic Courtès wrote:
> Any idea how many packages aside from GRUB are affected?  Would it work
> to simply provide the old Flex in addition to the new one, and have GRUB
> use it?

I don't have a good idea yet. When reconfiguring my headless GuixSD
system based on core-updates, the only affected package was GRUB, but
that system doesn't have many packages installed on it.

I added flex-2.6.1 and made GRUB use it in
af50d389c5ceaf978182c8d783a4d0e76c56655f.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: core-updates: flex is broken [was: GRUB fails to build]

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> On Mon, Mar 06, 2017 at 11:14:37AM +0100, Ludovic Courtès wrote:
>> Any idea how many packages aside from GRUB are affected?  Would it work
>> to simply provide the old Flex in addition to the new one, and have GRUB
>> use it?
>
> I don't have a good idea yet. When reconfiguring my headless GuixSD
> system based on core-updates, the only affected package was GRUB, but
> that system doesn't have many packages installed on it.
>
> I added flex-2.6.1 and made GRUB use it in
> af50d389c5ceaf978182c8d783a4d0e76c56655f.

Great, thanks!

Ludo’.