From: Leo Famulari <leo@famulari.name>
To: Mekeor Melire <mekeor.melire@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add dzen.
Date: Thu, 2 Mar 2017 18:51:20 -0500 [thread overview]
Message-ID: <20170302235120.GA20698@jasmine> (raw)
In-Reply-To: <871suftg6d.fsf@gmail.com>
On Fri, Mar 03, 2017 at 12:25:14AM +0100, Mekeor Melire wrote:
> From d235a347a21d50902d42f161a6c840516eff9d42 Mon Sep 17 00:00:00 2001
> From: Mekeor Melire <mekeor.melire@gmail.com>
> Date: Fri, 3 Mar 2017 00:22:47 +0100
> Subject: [PATCH] gnu: Add dzen.
>
> * gnu/packages/xdisorg.scm (dzen): New variable.
Thanks, pushed!
> + ;; Use own make-flags instead of `config.mk`.
> + (add-before 'build 'dont-include-config-mk
> + (lambda* (#:key outputs #:allow-other-keys)
> + (substitute* "Makefile" (("include config.mk") "")))))))
I also simplified this a bit and made the phase return #t. We like all
build phases to return #t or to fail, but (substitute*)'s return value
is unspecified, so we return #t from this sort of phase.
prev parent reply other threads:[~2017-03-02 23:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 23:28 [PATCH] gnu: Add dzen Mekeor Melire
2017-02-14 0:41 ` Leo Famulari
2017-02-22 0:10 ` Mekeor Melire
2017-03-02 2:34 ` Leo Famulari
2017-03-02 2:35 ` Leo Famulari
2017-03-02 23:25 ` Mekeor Melire
2017-03-02 23:51 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302235120.GA20698@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=mekeor.melire@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).